Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mods for running in NOAA #320

Closed
wants to merge 1 commit into from
Closed

mods for running in NOAA #320

wants to merge 1 commit into from

Conversation

rgrumbine
Copy link
Contributor

additions for running in NOAA

  • Developer(s):
    Robert Grumbine

  • Please suggest code Pull Request reviewers in the column at right.

  • Are the code changes bit for bit, different at roundoff level, or more substantial?
    Bit for bit

  • Please include the link to test results or paste the summary block from the bottom of the testing output below.

  • Does this PR create or have dependencies on Icepack or any other models?
    No

  • Is the documentation being updated with this PR? (Y/N)
    If not, does the documentation need to be updated separately at a later time? (Y/N)
    no, no

Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.

  • Other Relevant Details:
    clean launch, batch, env, and Macro file modifications / additions from newly re-forked CICE master

@apcraig
Copy link
Contributor

apcraig commented May 31, 2019

I believe this is redundant with #319? Should it be closed?

@rgrumbine
Copy link
Contributor Author

rgrumbine commented May 31, 2019 via email

@apcraig
Copy link
Contributor

apcraig commented May 31, 2019

OK, sounds good. travis is passing for this, so I think your new fork is good. The diffs also look fine. @rgrumbine , could you close this PR.

You can/should also update your fork master as follows

git clone https://github.com/rgrumbine/cice cice.master
cd cice.master
git remote add upstream https://github.com/cice-consortium/cice
git pull upstream master
git push origin master

Now your fork master will be synced with cice-consortium again. I do this everytime I checkout a new sandbox before creating a new branch and doing development. It's been helpful to me to keep my fork master clean and synced to the consortium master, and that's what's recommended in the consortium workflow. But if you have other ways you prefer to work, that's OK too.

@rgrumbine
Copy link
Contributor Author

Will do.

At the time I started, the consortium master had no changes relative to mine, so I didn't re-execute the pull upstream master. But yes, I have been and will continue the synchronization of my master with the consortium's.

@rgrumbine rgrumbine closed this May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants