Add ability for user to set test directory #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdturner
approved these changes
Feb 15, 2019
|
I tried the new tdir option and it seems to work only for test suites and not for single tests, is that normal ? |
|
Thanks @phil-blain, let me look into this. A quick code review suggests this was overlooked. I'll fix it if so. |
|
The tdir bug for single tests is included in PR #300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability for user to set test directory, addresses #275
Developer(s): apcraig
Are the code changes bit for bit, different at roundoff level, or more substantial? bit-for-bit
Does this PR create or have dependencies on Icepack or any other models? no
Is the documentation being updated with this PR? (Y/N) Y
Other Relevant Details:
Tested on conrad, bit-for-bit, also tested error modes.
Tested that documentation builds, https://apcraig-cice.readthedocs.io/en/se1/