Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the cicecore directory structure #17

Merged
merged 5 commits into from
Aug 7, 2017

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Aug 4, 2017

These changes were implemented on top of the cicetestA changes and only include changes to the directory structure and an update to the cice.build file to update Filepath to point to the new directories. Recommend this PR occur after cicetestA PR (#16).

apcraig added 3 commits August 4, 2017 10:26
…c0 over land after

initialization.  This supports bit-for-bit testing on different pe counts and different
decompositions where land block elmination might be different and results in all land tracer
values to be zero on history and restart files.

Updated the test scripts and added a new -td feature that allows test results to be compared
with each other.  Refactored some of the scripts to make them more flexible for the -td option.
Changed the test name convention so machine is the first item in the name.  This is to make
it easier to use the -td option.

Modified tests so now there are only smoke and restart tests.  Added new settings (run5day,
run10day, run1year, etc) to support different length smoke tests.  Refactored the test
scripts so there is a test_smoke.script and a test_restart.script now.  Moved the main
test script from under tests to the scripts directory and renamed it to cice.test.setup.csh.
Updated the README.test.

Updated the base_suite file to add new tests and make testnames conform to new convention.

Changed the restart test to be a 10 day run with restart at day 5.

Added other new options to support different batch wall times (short, medium long), support
modifications for grids (gx1, gx3), to turn on the bfbflag (bfbflagT).

Added some new error checks to make sure create.case aborts if there is a problem detected.

Modified create.case -h so it now automatically generates the list of -s options and the
list of -t tests as part of the documentation.

These results are bit-for-bit over the ocean and not bit-for-bit over land for some tracers.
Update the cicecore directory structure and modify the Makefile so the filepath
points to the updated directories
@apcraig apcraig requested a review from eclare108213 August 4, 2017 18:41
Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me.

@apcraig apcraig merged commit 3510188 into CICE-Consortium:master Aug 7, 2017
srethmeier added a commit to dmidk/CICE that referenced this pull request Jul 29, 2021
JFLemieux73 pushed a commit to JFLemieux73/CICE that referenced this pull request Nov 18, 2021
CICE-Consortium#17)

* Changes in ice_dyn* are interpolation of uvelE/vvelN to B grid. ice_transport files are changed in a way so that velocities are interpolated to b grid for depature point function and kept at E or N grid possible.

* changed according to comments. changed average from F to S and. commented out in vp and eap

* comment out grid_system, uvelE and vvelN
@apcraig apcraig deleted the newdirs branch August 17, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants