-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the cicecore directory structure #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c0 over land after initialization. This supports bit-for-bit testing on different pe counts and different decompositions where land block elmination might be different and results in all land tracer values to be zero on history and restart files. Updated the test scripts and added a new -td feature that allows test results to be compared with each other. Refactored some of the scripts to make them more flexible for the -td option. Changed the test name convention so machine is the first item in the name. This is to make it easier to use the -td option. Modified tests so now there are only smoke and restart tests. Added new settings (run5day, run10day, run1year, etc) to support different length smoke tests. Refactored the test scripts so there is a test_smoke.script and a test_restart.script now. Moved the main test script from under tests to the scripts directory and renamed it to cice.test.setup.csh. Updated the README.test. Updated the base_suite file to add new tests and make testnames conform to new convention. Changed the restart test to be a 10 day run with restart at day 5. Added other new options to support different batch wall times (short, medium long), support modifications for grids (gx1, gx3), to turn on the bfbflag (bfbflagT). Added some new error checks to make sure create.case aborts if there is a problem detected. Modified create.case -h so it now automatically generates the list of -s options and the list of -t tests as part of the documentation. These results are bit-for-bit over the ocean and not bit-for-bit over land for some tracers.
Update the cicecore directory structure and modify the Makefile so the filepath points to the updated directories
eclare108213
approved these changes
Aug 4, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look fine to me.
srethmeier
added a commit
to dmidk/CICE
that referenced
this pull request
Jul 29, 2021
Fix evp 1d masking issues
JFLemieux73
pushed a commit
to JFLemieux73/CICE
that referenced
this pull request
Nov 18, 2021
CICE-Consortium#17) * Changes in ice_dyn* are interpolation of uvelE/vvelN to B grid. ice_transport files are changed in a way so that velocities are interpolated to b grid for depature point function and kept at E or N grid possible. * changed according to comments. changed average from F to S and. commented out in vp and eap * comment out grid_system, uvelE and vvelN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were implemented on top of the cicetestA changes and only include changes to the directory structure and an update to the cice.build file to update Filepath to point to the new directories. Recommend this PR occur after cicetestA PR (#16).