Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poll_queue script / general csh usage #299

Closed
phil-blain opened this issue Mar 15, 2019 · 6 comments
Closed

poll_queue script / general csh usage #299

phil-blain opened this issue Mar 15, 2019 · 6 comments

Comments

@phil-blain
Copy link
Member

I tried using the poll_queue.csh script on my machine (ubuntu 14.04) and it fails ; it just outputs
end: No match.
However, when I run it under tcsh instead of plain csh (by changing the shebang), it works.

On my system I have the following links:
/bin/csh -> /etc/alternatives/csh -> /bin/bsd-csh

So it seems the csh version that comes with ubuntu is not capable of running this script. I think this should be documented, and maybe we should change the shebang for this script (and maybe others? from what I read csh has a reputation of being buggy...)

@phil-blain
Copy link
Member Author

The line
set res="$?"
in the cice.test script is also causing a problem with my csh:
Illegal variable name.
It works fine with tcsh.

@apcraig
Copy link
Contributor

apcraig commented Mar 18, 2019

Portability of these scripts is very important. If you switch the poll_queue script to tcsh, everything works fine? Any idea what's causing problems in that script for you?

Also, does $status work better than $? for you in your csh environment?

@phil-blain
Copy link
Member Author

phil-blain commented Mar 19, 2019

poll_queue.csh
Yes, if I use tcsh the poll_queue script works. From what I was able to deduce using set verbose, when using csh the line
foreach line ( "`cat suite.log`" )
in poll_queue has a problem with the line
rm -f *.f *.f90 *.d *.mod *.o /users/dor/afsg/phb/local/CICEDIRS/CICE_RUNS/cesium_intel_smoke_gx3_1x1_diag1_run1day.quick6.0/cice
in suite.log; if I remove that line in the log file, the script continues up to the first linking line in the log, where it errors with
Word too long.
If I also remove the linking line, it errors at the line
if ($? != 0) then
with Illegal variable name.

If I replace $? with $status it then works.

cice.test
If I replace $? with $status it works.

@phil-blain
Copy link
Member Author

Also, on a different note:
The poll_queue script is only copied to the suite directory if the suite is created with the --report option (line 372 in cice.setup). I think this script is useful even if the user is not reporting the test results back to the wiki, so I think it should always be copied.

@apcraig
Copy link
Contributor

apcraig commented Mar 20, 2019

This is being fixed in #300. I have replaced $? with $status and have refactored the poll_queue so it does not parse the suite.log file. I am also copying the poll_queue script into the test suite directory for all suites.

apcraig added a commit to apcraig/CICE that referenced this issue Mar 20, 2019
apcraig added a commit that referenced this issue Mar 27, 2019
* implement bfb for mpi comm global sums, fix compile issue with cpps, remove unused cpps

* add set_nml.reprosum

* update global reductions for serial mode to leverage bfbflag in the same way as mpi mode

* update and fix bfb compare feature

* add comparelog.csh script and logbfb test

* update travis gcc, fix tdir feature with tests

* update Makefile for c compiles, update Macros files to support c compile and serial/parallel compiles better and cleaner

* modify report results script to address grep for bfbcomp cases, add first_suite.ts

* fix Macros.onyx_intel, accidently removed debug flags in earlier commit

* update travis c build

* fix script logic for more threads than tasks per node

* update scripts to address #299, poll_queue script and #301, single test bgen default use

* add QSTAT variables to fram and cesium
@apcraig
Copy link
Contributor

apcraig commented Mar 27, 2019

PR #300 complete

@apcraig apcraig closed this as completed Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants