Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN 1.2 Prep #209

Merged
merged 11 commits into from
Oct 23, 2024
Merged

CRAN 1.2 Prep #209

merged 11 commits into from
Oct 23, 2024

Conversation

rsh52
Copy link
Collaborator

@rsh52 rsh52 commented Oct 16, 2024

Description

This PR addresses notes and makes a few subtle changes to accommodate an oversight in repeat event definitions. Changes listed below:

  • Several documentation links to external packages caused NOTE returns, these have been changes to backticks instead.
  • One of the databases from OUHSC no longer works with the credential we have and is now skipped when running microbenchmark checks
  • In combine_checkboxes() and check_equal_col_summaries() global variable NOTEs were returned for ., .value, and .new_value. The structural changes below have resolved this.
  • The recent changes from Missing Data Fix, Partial Keys Fix #205 involving introducing repeat_type under the repeat_events col of the supertibble didn't account for longitudinal databases with no repeating architecture. The changes to add_event_mapping and read_redcap() should now appropriately accommodate longitudinal databases with and without repeating instances for forms and events.
  • CRAN Comments prepped, NEWS prepped, RHub run successfully
  • Microbenchmark results updated

Remaining TODOs and notes:

  • Microbenchmark results seem to have gone up, not IMO alarmingly and IIRC this can at times just be the time of day or the fact a lot of our databases are getting larger. But worth noting.
  • Some of the cli messages updated. I believe these are mostly related to message returns updating from REDCapR and how we mirror what it returns.
  • Revdepcheck is deprecated, and we have the structure in place for using the new recheck workflow. However this is currently failing because of renv.
    • I don't think this will be easily solvable since the steps used to build and install dependencies are under a sub-workflow of recheck
    • IMO it might be time to bail on renv, in meeting with the ggplot2 devs it came up again that folks were surprised and frowned upon using renv in package development. Thoughts @ezraporter?
    • This is the last piece needed for the CRAN-Comments file
  • In the future we may want to have some aspect of our pkgdown highlighting combine_checkboxes() but I don't think we need that now.

Thanks!

@rsh52 rsh52 added bug Something isn't working documentation Improvements or additions to documentation labels Oct 16, 2024
@rsh52 rsh52 self-assigned this Oct 16, 2024
@rsh52 rsh52 marked this pull request as ready for review October 16, 2024 19:20
@rsh52 rsh52 requested a review from ezraporter October 16, 2024 19:20
@rsh52 rsh52 marked this pull request as draft October 16, 2024 19:20
@ezraporter
Copy link
Collaborator

  • IMO it might be time to bail on renv, in meeting with the ggplot2 devs it came up again that folks were surprised and frowned upon using renv in package development. Thoughts @ezraporter?

Okay I'm fine with this. We've clearly been outvoted and people are building tools that aren't compatible with renv in this area.

@rsh52 rsh52 marked this pull request as ready for review October 23, 2024 20:19
@rsh52 rsh52 merged commit 33d95e4 into main Oct 23, 2024
4 checks passed
@rsh52 rsh52 deleted the cran-1.2-prep branch October 23, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants