depth bounds mesh size enforcement #230
Conversation
krober10nd
commented
Jun 17, 2021
•
krober10nd
commented
- enforce the function between min and max depth bounds.
* enforce the wavelength function between 10-m deep and infinity bathymetry by default.
|
we should address this #154 and also make all sizing functions consistent w.r.t. to the depth bound ranges the parameter is enforced on. |
|
Yes definitely need to make the depth bound criteria much easier to understand like suggested in #154 and make it consistent for all sizing functions, and add some information in the help. |
krober10nd
changed the title
|
The |
* Change maximum mesh resolution bound to 500 m overland.
…description - In `edgefx` change all so-called depth bounds variables to z_min/z_max bounds to correctly represent that it is actually a topographic elevation bound - add helper information for `edgefx` on the different variable types for each input and description of the topographic elevation bound structure - correct description of elevation bounds in `Example_6b`
There was a problem hiding this comment.
I made the changes to be consistent across all options and to make clear to us and the user that is an elevation bound not a depth bound (i.e, negative is underwater, same as DEM).
Checked the result on the Example_6b and mesh resolution distribution plot looks correct.
|
Okay thanks. Let’s update the change log so it refs this pull request and then merge it. |
