-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Precise nearest neighbor mapping for extremely close points (e.g., weirs/levess) #207
Conversation
…y over weirs routine since sometimes the weir points can be so close toghether that the precision of ANN ourKNNsearch fails while matlab's knnsearch works
wow how thin are your weirs that this is a problem? |
So they made them on top of each other but to get it work with OM2D I moved them slightly by around ~1e-6 deg |
ah okay 10 cm. seems reasonable :] |
Did you see the small change in #206 ? I had to make these arrays column otherwise I could not carry over. |
Added code for toggling plotting of fort.24 in Make_f24 and fixing slope_calc bug in #208 |
Is this completed to warrant running all the tests? |
yes it's completed |
I'll make a new PR for improving the make_bc |
I guess. I thought that we had used OurKnnsearch for labeling boundaries. |
this PR doesn't use that change. Only for carrying over weirs. Otherwise the "approximate" nearest neighbor (i.e. ourKNNsearch) is used. |
All tests/examples worked out (we'll need to do a different PR to highlight the API change in |
adding precise option (calls Matlab's native knnsearch) in nearest_neighbor_map and calling in the carry over weirs routine since sometimes the weir points can be so close together that the precision of ANN ourKNNsearch fails while matlab's knnsearch works
I added a check for the presence of knnsearch in case the user doesn't have it.