Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update HIPCC to preserve ordering #899

Merged
merged 2 commits into from
Jul 30, 2024
Merged

update HIPCC to preserve ordering #899

merged 2 commits into from
Jul 30, 2024

Conversation

pvelesko
Copy link
Collaborator

@pvelesko pvelesko commented Jul 29, 2024

Fixes #898

TODO:

  • merge HIPCC into develop

@pvelesko
Copy link
Collaborator Author

@jjennychen please check this PR. Make sure to git submodule update once you checkout

@jjennychen
Copy link
Collaborator

@pvelesko Just tested, works perfectly! Thanks a lot!!
Here is the ordering that I got from this PR (for your reference):

/home/tsaini.chen/install/llvm/17.0/bin/clang++ -include /home/tsaini.chen/install/chipStar/test_ordering/include/hip/spirv_fixups.h -I//home/tsaini.chen/install/chipStar/test_ordering/include -isystem /home/tsaini.chen/install/chipStar/test_ordering/include/cuspv -include /home/tsaini.chen/install/chipStar/test_ordering/include/cuspv/cuda_runtime.h -D__NVCC__ -D__CHIP_CUDA_COMPATIBILITY__ -std=c++14 -Wall -Ddfloat=float -Ddlong=int -O3 -lgfortran main.o meshBasis.o BlasLapack/libBlasLapack.a BlasLapack/libBlasLapack.a -o main -L/home/tsaini.chen/install/chipStar/test_ordering/lib -lCHIP -no-hip-rt -locml_host_math_funcs -Wl,-rpath,/home/tsaini.chen/install/chipStar/test_ordering/lib

@pvelesko pvelesko merged commit 163015d into main Jul 30, 2024
31 checks passed
@pvelesko pvelesko deleted the fix-898 branch July 30, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NVCC compilation flags/options ordering
2 participants