Fix bunch texture cases #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix used device pointer as source image data for clEnqueueWriteImage() which is not (guaranteed) to work unless it points to fine-grained SVM allocation.
Fix get1DRegion() had unrelated parameter which effectively caused element size to be ignored.
spirv_channel_descriptor.h had multiple hipCreateChannelDesc() specializations setting incorrect hipChannelFormatKind value. Fix by importing the more recent hipCreateChannelDesc implementations from the original source (hipamd).
pvelesko
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clEnqueueWriteImage()which is not (guaranteed) to work unless it points to fine-grained SVM allocation.get1DRegion()had unrelated parameter which effectively caused element size to be ignored.hipCreateChannelDesc()specializations setting incorrecthipChannelFormatKindvalue. Fix by importing the more recenthipCreateChannelDesc()implementations from the original source (hipamd).DEF_TEX2D_VEC4macro.