Backend handles refactor #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvelesko
force-pushed
the
expand-handles
branch
from
9aea2a1 to
548e42a
Compare
pvelesko
force-pushed
the
expand-handles
branch
from
bfc18df to
75708d7
Compare
|
I'll probably roll |
Kerilk
reviewed
Feb 28, 2024
samples/hip_sycl_interop_no_buffers/onemkl_gemm_wrapper_no_buffers/onemkl_gemm_wrapper.cpp
Outdated
Show resolved
Hide resolved
Kerilk
reviewed
Feb 28, 2024
samples/hip_sycl_interop_no_buffers/onemkl_gemm_wrapper_no_buffers/onemkl_gemm_wrapper.cpp
Outdated
Show resolved
Hide resolved
…fers/onemkl_gemm_wrapper.cpp Co-authored-by: Brice Videau <[email protected]>
pvelesko
force-pushed
the
expand-handles
branch
from
f0c2bda to
836232e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor how backend handles are returned.
hipGetBackendNativeHandlesis now to be called twice - once to get the number of handles and second time to populate the allocated handle array.