Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process -fgpu-rdc #4

Closed
wants to merge 2 commits into from
Closed

Process -fgpu-rdc #4

wants to merge 2 commits into from

Conversation

linehill
Copy link

@linehill linehill commented Mar 3, 2023 •
edited
Loading

This patch is for completing PR CHIP-SPV/chipStar#377 in CHIP-SPV.

  • Extract additional flags needed for -fgpu-rdc flags from HIP_OFFLOAD_RDC_SUPPLEMENT_LINK_OPTIONS variable in .hipInfo.

  • Strip duplicate --offload options coming from multiple variables in .hipInfo.

  • Remove hard coded --target option which causes "clang-offload-bundler: error: Can't find bundle for the host
    target" error.

@linehill linehill mentioned this pull request Mar 3, 2023
Merged
3 tasks
@linehill linehill marked this pull request as ready for review March 6, 2023 11:21
linehill added 2 commits April 21, 2023 13:49
@linehill
Process -fgpu-rdc
0c7839d 
* Extract additional flags needed for -fgpu-rdc flags from
  HIP_OFFLOAD_RDC_SUPPLEMENT_LINK_OPTIONS variable in .hipInfo.

* Strip duplicate --offload options coming from multiple variables in
  .hipInfo.
@linehill
Fix clang-offload-bundler error
4da2fd1 
Fix "clang-offload-bundler: error: Can't find bundle for the host
target" because of the hard coded `--target=x86_64-linux-gnu` option
clashed with `--target` option propagated via `.hipInfo`.
@pvelesko
Copy link
Collaborator

Failing tests:

29% tests passed, 5 tests failed out of 7

Total Test time (real) =  12.79 sec

The following tests FAILED:
	 13 - hipcc-TestHipccAcceptCcFiles (Failed)
	 15 - TestHipccNeedsDashO (Failed)
	 17 - TestHipccHalfConversions (Failed)
	 18 - TestHipccHalfOperators (Failed)
	 20 - TestHipccCompileAndLink (Failed)

Since CI is setup only on CHIP-SPV repo, for the time being it would be easier to update the submodule there so that it gets checked out and tests ran.

@pvelesko
Copy link
Collaborator

oh I see this branch needs a rebase - I'll rebase and test again

@pvelesko
Copy link
Collaborator

nope, still failing. I'll fix & merge

@linehill
Copy link
Author

Rebased. Sorry I didn't see your comments in time.

@pvelesko pvelesko mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linehill @pvelesko