Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Batch import creates ABP tags in Device Twin for OTAA-based device models #2985

Open
Metal-Mighty opened this issue May 7, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Metal-Mighty
Copy link
Contributor

Expected Behavior

When importing a list of devices from the provided CSV template file, the portal should check the type of device authentication before creating it, and only set values for the proper authentication method (OTAA or ABP)

Current Behavior

The portal creates OTAA devices with all properties set (with values or empty strings depending on what's provided), which causes the devices to fail loading in the LoRa Network Server due to the presence of ABP variables in the Device Twin (e.g. AppSKey).

Steps to Reproduce

  1. Get the import template
  2. Add an OTAA device without filling the ABP-specific columns
  3. Import in the portal
  4. Connect the device to your LoRa network

Context (Environment)

Portal version: 4.13.2
LoRaWAN Stack version: 2.2.2

Logs

image

Additional Information

image

@Metal-Mighty Metal-Mighty added the bug Something isn't working label May 7, 2024
@github-project-automation github-project-automation bot moved this to 📝 Todo in IoT Hub Portal May 7, 2024
@adcoly
Copy link

adcoly commented May 16, 2024

Removing those 3 parameters from the csv template does not fix the issue.
By the way, "TAG:supportLoRaFeatures" field is missing in the template.

@Metal-Mighty Metal-Mighty added this to the v6.0 milestone Jul 19, 2024
@judramos judramos self-assigned this Nov 12, 2024
@judramos judramos moved this from 📝 Todo to 🚧 In Progress in IoT Hub Portal Nov 12, 2024
@judramos
Copy link

If AppKey and AppEUI are filled, ABP properties (NwkSKey, AppSKey and DevAddr) are not setted in the device twin in azure.

@judramos judramos linked a pull request Nov 29, 2024 that will close this issue
9 tasks
kbeaugrand added a commit that referenced this issue Dec 5, 2024
* Add of layerId in device twin

* #2998 Quartz migration for SendPlanningCommand

* #2856 Disable built-in device model deletion

* #3238 Update view when a device is unchecked

* 3239 Allow to delete a planning from client

* 3239 Allow to delete a planning

* 2998 Schedule commands

* #3239 Change checkboxes for layers displayed

* Merge from main

* 2516 add supportLoRaFeatures tag in template file

* #3250 Import device list using the template given

* #2985 Batch import creates ABP tags in Device Twin for OTAA-based device models

* #3251 Import device - data overwritten

* Unit tests

* Update src/IoTHub.Portal.Infrastructure/Jobs/SendPlanningCommandJob.cs

Co-authored-by: Kevin BEAUGRAND <[email protected]>

* #2958 Remove 'Connection State' and 'Last status update' columns

* #3023 startupOrder not supported in Edge Device Model schema

---------

Co-authored-by: E068097 <[email protected]>
Co-authored-by: judramos <[email protected]>
kbeaugrand added a commit that referenced this issue Dec 5, 2024
* Add of layerId in device twin

* #2998 Quartz migration for SendPlanningCommand

* #2856 Disable built-in device model deletion

* #3238 Update view when a device is unchecked

* 3239 Allow to delete a planning from client

* 3239 Allow to delete a planning

* 2998 Schedule commands

* #3239 Change checkboxes for layers displayed

* Merge from main

* 2516 add supportLoRaFeatures tag in template file

* #3250 Import device list using the template given

* #2985 Batch import creates ABP tags in Device Twin for OTAA-based device models

* #3251 Import device - data overwritten

* Unit tests

* Update src/IoTHub.Portal.Infrastructure/Jobs/SendPlanningCommandJob.cs

Co-authored-by: Kevin BEAUGRAND <[email protected]>

* #2958 Remove 'Connection State' and 'Last status update' columns

* #3023 startupOrder not supported in Edge Device Model schema

---------

Co-authored-by: E068097 <[email protected]>
Co-authored-by: judramos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 💬 Ready for Review
Development

Successfully merging a pull request may close this issue.

3 participants