Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to previous settings when exiting tool #1355

Closed
jlampel opened this issue Nov 26, 2024 · 5 comments
Closed

Switch back to previous settings when exiting tool #1355

jlampel opened this issue Nov 26, 2024 · 5 comments
Assignees
Labels
Milestone

Comments

@jlampel
Copy link
Member

jlampel commented Nov 26, 2024

RetopoFlow enables certain snapping, auto-merge, and viewport overlay settings when switching to one of the tools. Currently only the retopology overlay is disabled when exiting the tool, but all previous settings should be restored as well.

@jlampel jlampel added enhancement v4 Applies to RF version 4x labels Nov 26, 2024
@jlampel jlampel changed the title Switch back to previous setting when exiting tool Switch back to previous settings when exiting tool Nov 26, 2024
@jlampel
Copy link
Member Author

jlampel commented Nov 26, 2024

Along with this, user changes to the settings while a RetopoFlow tool is active should be saved on exit for the next time the tool is active. For example, I need to change the auto-merge distance from 0.01 to 0.001, but when I change tools and come back, it has reverted back to 0.01.

Side note, RF probably doesn't need to touch the distance setting as that is highly specific to each project

@vxlcoder
Copy link
Contributor

i have code in place to do this (or at least it should). do you have specific cases where it isn't happening, so I can look more closely?

i've already removed the changing of auto-merge distance, so that's done.

note: it's not clear how to handle case when blender saves a blend file with properties adjusted by RF, as there's not a clear way to store previous setting across save/load (maybe a scene property??). for example, start up file.

@jlampel jlampel added this to the v4.0 milestone Dec 5, 2024
@jlampel
Copy link
Member Author

jlampel commented Dec 5, 2024

It looks like everything is actually reverted except for the Snap Target. That gets stuck on Face Nearest.

A scene property would probably be the best way to store scene settings across sessions. I do that in a few other add-ons, and it seems to work well.

vxlcoder added a commit that referenced this issue Jan 13, 2025
now, RF remembers `snap_elements_base` so that it can be restored
properly.

`snap_elements_base` and `snap_elements_individual` are separate
settings, but changing one affects the other.
@vxlcoder
Copy link
Contributor

should be fixed now!

@jlampel
Copy link
Member Author

jlampel commented Jan 13, 2025

Works great! Thank you!

@jlampel jlampel closed this as completed Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants