Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass random instance to GeneratorOnObject in Generic_random_point_generator for consistency #8420

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

chudonghao
Copy link
Contributor

@chudonghao chudonghao commented Aug 21, 2024

Summary of Changes

sample_triangle_mesh was passed a random seed but did not produce stable results.

Pass random instance to GeneratorOnObject in Generic_random_point_generator for consistency

Release Management

  • Affected package(s): PMP

@afabri
Copy link
Member

afabri commented Aug 21, 2024

Thank you for this fix.

@sloriot
Copy link
Member

sloriot commented Sep 3, 2024

Successfully tested in CGAL-6.0-Ic-318

@sloriot sloriot merged commit ce544fb into CGAL:master Sep 3, 2024
8 checks passed
@chudonghao chudonghao deleted the Pass_random_to_GeneratorOnObject branch September 27, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants