Make triangulate_faces deterministic #8129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrineau
reviewed
Apr 8, 2024
|
|
||
| halfedge_descriptor res = boost::graph_traits<PolygonMesh>::null_halfedge(); | ||
|
|
||
| if (p1p3!=p0p2) |
There was a problem hiding this comment.
Maybe we should have a predicate. Because here we compare computed values, without an exact kernel.
There was a problem hiding this comment.
How do you want to call it? Comparison_result fct(const Point_& p0,..... p3)
There was a problem hiding this comment.
Also the code might profit from computing some differences only once.
There was a problem hiding this comment.
I don't think there is any need to use an exact predicate here. I don't think we could select an invalid diagonal.
|
Successfully tested in 6.0-Ic-224 |
lrineau
added
the
rm only: ready for master
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triangulate quads the same way