Autorefinement: insert points in edge to avoid filter failures #8023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbinatoric of the intersection points
… no segments case
Intersections_3/include/CGAL/Intersections_3/internal/Triangle_3_Triangle_3_intersection.h
Show resolved
Hide resolved
sloriot
added
Under Testing
Batch_1
|
Successfully tested in CGA-6.0-Ic-173 (but TODOs remaining) |
sloriot
added
Under Testing
and removed
TODO
Batch_1
|
There are some runtime errors in CGAL-6.0-Ic-176 |
afabri
reviewed
Feb 22, 2024
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/autorefinement.h
Outdated
Show resolved
Hide resolved
This reverts commit a57800c. points vector of Triangle_data can be updated when intersecting new intersection points. If the container is used at the same time by another thread calling generate_subtriangles, the container might be in an invalid state while resizing it.
|
Successfully tested in CGAL-6.0-Ic-181 |
lrineau
added
the
rm only: ready for master
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect intersection points on edges and in faces to use CDT dedicated functions.
Also add structural filtering with projection traits and restore "classical" projection traits for testing.