Installation - fix CGAL_ITK_support

[janetournois]

Summary of Changes

This PR modifies CGAL_ITK_support.cmake, so that it uses imported targets from ITKConfig.cmake.

Note that for now

• the line include(${ITK_USE_FILE}) is still needed
• the module ITKThresholding does not have a lib, so we do not link the libraries and only include the files

Release Management

• Affected package(s): Installation, and the CMakeLists of Mesh_3
• Issue(s) solved (if any): fix Issue with CGAL ITK_Support #7855
• License and copyright ownership: unchanged

[janetournois]

The error in the CI is the following

/usr/bin/ld: cannot find -lITKSmoothing: No such file or directory
/usr/bin/ld: cannot find -lITKImageIntensity: No such file or directory

@SaillantNicolas can you please check how ITK is installed on the CI machine, and if these libs are really not available?
It is working with my windows setup.

cc @lrineau

[lrineau]

The error in the CI is the following

/usr/bin/ld: cannot find -lITKSmoothing: No such file or directory
/usr/bin/ld: cannot find -lITKImageIntensity: No such file or directory

@SaillantNicolas can you please check how ITK is installed on the CI machine, and if these libs are really not available? It is working with my windows setup.

cc @lrineau

I think I fixed that with the three commits https://github.com/CGAL/cgal/pull/7858/files/0b73361226b11e06520c32970178e016cc0d200d..0a9392c778ab7e485603ed0658e1f679b0be44bb.

I used https://github.com/nektos/act to first verify locally (using act's Docker images), to create cb5bd56. Then there was an issue with Github's version of Ubuntu. Fixed in 0a9392c.

@SaillantNicolas You should install https://github.com/nektos/act on your machine. That is a very useful tool to test Github workflows on your local machine.

[lrineau]

... Actually it was fixed by commit 74896b9: install ITK 5 instead of ITK 4.

[janetournois]

In the testsuite CGAL-6.0-Ic-112, 2 platforms are failing because of this PR (Ubuntu-Latest-NO_DEPRECATED_CODE and Ubuntu-GCC_master_CXX20-Release), complaining about

/usr/bin/ld: cannot find -lITKSmoothing: No such file or directory
/usr/bin/ld: cannot find -lITKImageIntensity: No such file or directory

and with lots of warnings from ITK-4.13.

Is it possible to update those 2 platforms to ITK-5, and add the needed libraries please? @sloriot

[lrineau]

In the testsuite CGAL-6.0-Ic-112, 2 platforms are failing because of this PR (Ubuntu-Latest-NO_DEPRECATED_CODE and Ubuntu-GCC_master_CXX20-Release), complaining about

/usr/bin/ld: cannot find -lITKSmoothing: No such file or directory
/usr/bin/ld: cannot find -lITKImageIntensity: No such file or directory

and with lots of warnings from ITK-4.13.

Is it possible to update those 2 platforms to ITK-5, and add the needed libraries please? @sloriot

Actually, there are Linux distributions (including the one I use: Fedora 39) that are currently stuck with ITK version 4.13, and I would like to stay compatible with that version of ITK. I will modify this PR accordingly.

[lrineau]

In commit 9262c6a I have re-added a file CGAL_ITK_support.cmake and an imported target CGAL::ITK_support. That imported target uses imported targets from ITK, and should be compatible with both ITK versions 4.13 and 5.x.

[afabri]

Errors in the testsuite

[lrineau]

Errors in the testsuite

The last merged commit for that testsuite was not the last one (9262c6a9) but the one before (74896b9). Probably my push arrived too late yesterday.

[sloriot]

Successfully tested in CGAL-6.0-Ic-116