Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLS: Fix warnings #7561

Merged
merged 2 commits into from
Sep 7, 2023
Merged

SLS: Fix warnings #7561

merged 2 commits into from
Sep 7, 2023

Conversation

afabri
Copy link
Member

@afabri afabri commented Jun 29, 2023 •
edited
Loading

Summary of Changes

Fix warnings in testsuite

Release Management

  • Affected package(s): Straight_line_skeleton

@afabri afabri added this to the 6.0-beta milestone Jun 29, 2023
MaelRL
MaelRL reviewed Jul 3, 2023
View reviewed changes
Copy link
Member

@MaelRL MaelRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should rather be a change in the definition of weights (value type is an integral type, and it should be double)

@lrineau lrineau added Not yet approved The feature or pull-request has not yet been approved. Under discussion labels Jul 5, 2023
@sloriot
Copy link
Member

sloriot commented Jul 13, 2023

Successfully tested in CGAL-6.0-Ic-22.
Warning is gone: https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0-Ic-22/Straight_skeleton_2/TestReport_Christo_MSVC-2019-Community-Release.gz

@lrineau
Copy link
Member

lrineau commented Jul 17, 2023 •
edited by MaelRL
Loading

I think it should rather be a change in the definition of weights (value type is an integral type, and it should be double)

@MaelRL @afabri You should discuss that topic today.

@github-actions github-actions bot removed the Tested label Jul 26, 2023
@github-actions
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@MaelRL MaelRL added Warnings For an issue about warnings, or a pull-request that fixes warnings and removed Under discussion Not yet approved The feature or pull-request has not yet been approved. labels Jul 26, 2023
@MaelRL MaelRL removed their assignment Aug 4, 2023
@sloriot
Copy link
Member

sloriot commented Sep 6, 2023

Successfully tested in CGAL-6.0-Ic-56

@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Sep 6, 2023
@lrineau lrineau self-assigned this Sep 6, 2023
@lrineau lrineau merged commit bf027d4 into CGAL:master Sep 7, 2023
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Sep 7, 2023
@lrineau lrineau deleted the SLS-warnings-GF branch September 7, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaelRL MaelRL MaelRL left review comments

Assignees

@lrineau lrineau

Labels
Merged_in_6.0 Pkg::Straight_skeleton_2 Tested Warnings For an issue about warnings, or a pull-request that fixes warnings
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@afabri @sloriot @lrineau @MaelRL