Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying npm for jQuery and Bootstrap Upgrades #31

Merged
merged 21 commits into from
Apr 25, 2024

Conversation

SaillantNicolas
Copy link
Member

No description provided.

@github-actions
Copy link

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

@github-actions
Copy link

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

@lrineau
Copy link
Member

lrineau commented Oct 16, 2023

A few initial remarks.

The browser console shows two HTTP errors 404:

GET
https://cgal.github.io/assets/themes/cgal/bootstrap/fonts/glyphicons-halflings-regular.woff
[HTTP/2 404  11ms]

downloadable font: download failed (font-family: "Glyphicons Halflings" style:normal weight:400 stretch:100 src index:1): status=2147746065 source: https://cgal.github.io/assets/themes/cgal/bootstrap/fonts/glyphicons-halflings-regular.woff
GET
https://cgal.github.io/assets/themes/cgal/bootstrap/fonts/glyphicons-halflings-regular.ttf
[HTTP/2 404  13ms]

downloadable font: download failed (font-family: "Glyphicons Halflings" style:normal weight:400 stretch:100 src index:2): status=2147746065 source: https://cgal.github.io/assets/themes/cgal/bootstrap/fonts/glyphicons-halflings-regular.ttf 

I also see that a few older JavaScript files are found in the old Booststrap directory in assets/:

    <!-- Javascripts -->
    <script src="/cgal-web/node_modules/jquery/dist/jquery.min.js"></script>
    <script>window.jQuery || document.write('<script src="/cgal-web/node_modules/jquery/dist/jquery.min.js"><\/script>')</script>
      <script src="/cgal-web/node_modules/bootstrap/dist/js/bootstrap.min.js"></script>
      <script src="https://cgal.github.io/cgal-web/assets/themes/cgal/bootstrap/js/jquery.fitvids.js"></script>
      <script src="https://cgal.github.io/cgal-web/assets/themes/cgal/bootstrap/js/jquery.sequence-min.js"></script>
      <script src="https://cgal.github.io/cgal-web/assets/themes/cgal/bootstrap/js/jquery.bxslider.js"></script>
      <script src="https://cgal.github.io/cgal-web/assets/themes/cgal/bootstrap/js/template.js"></script>
      <script src="/cgal-web/node_modules/bootstrap-hover-dropdown/bootstrap-hover-dropdown.min.js"></script>
    </body>
</html>

That is probably a problem.

@github-actions
Copy link

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

@github-actions
Copy link

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

@github-actions
Copy link

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

Copy link

github-actions bot commented Nov 2, 2023

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

Copy link

github-actions bot commented Nov 2, 2023

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

Copy link

github-actions bot commented Nov 6, 2023

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

Copy link

github-actions bot commented Nov 7, 2023

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

@lrineau
Copy link
Member

lrineau commented Nov 7, 2023

I think there is still work to do on style.css, and assets/themes/cgal/main.css. There are a lot of redundante styles. Let's do that tomorrow.

Copy link

github-actions bot commented Dec 6, 2023

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

@MaelRL
Copy link
Member

MaelRL commented Dec 7, 2023

Here are a few things that need fixing:

Copy link

github-actions bot commented Jan 4, 2024

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

Copy link

github-actions bot commented Jan 4, 2024

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

Copy link

github-actions bot commented Jan 4, 2024

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

Copy link

github-actions bot commented Jan 5, 2024

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

@lrineau
Copy link
Member

lrineau commented Jan 8, 2024

* [x]  intermediate looks like [cgal.org/April11](https://www.cgal.org/April11/) are no longer accessible? (You can still access to the subpages, but the April11 (and others) will return "This page does not exist".)

That is a server setting. The server at https://www.cgal.org/ run Apache, and has the option DirectoryIndex. But the server at https://cgal.github.io/ does not create directory indices. Once this PR will be merged and deployed to https://www.cgal.org/, the directory indices will be back.

@lrineau
Copy link
Member

lrineau commented Jan 8, 2024

* [x]  Pages are even gone? e.g. [cgal.org/Events/UserWorkshop](https://www.cgal.org/Events/UserWorkshop/) vs [cgal.github.io/cgal-web/Events/UserWorkshop](https://cgal.github.io/cgal-web/Events/UserWorkshop/)

That page was supposed to be removed by 99799d1. But the way we synchronized the web site with www.cgal.org does not remove files (we use rsync without the option to remove files). The page https://www.cgal.org/Events/UserWorkshop/ should be a directory index, and not the page that is served.

Copy link

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

Copy link

github-actions bot commented Apr 9, 2024

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

Copy link

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

1 similar comment
Copy link

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

@lrineau
Copy link
Member

lrineau commented Apr 23, 2024

@MaelRL @SaillantNicolas Let me know once you agree this PR is ready for merge.

Copy link

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

Copy link

The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html

@lrineau lrineau merged commit 1038e65 into CGAL:master Apr 25, 2024
1 check passed
@lrineau lrineau deleted the update-bootstrap-jquery-GF branch April 25, 2024 14:18
@lrineau
Copy link
Member

lrineau commented Apr 25, 2024

Thanks @SaillantNicolas, and @MaelRL for the review and suggestions.

I have merge the PR, to avoid any more copy-pasting errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants