-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applying npm for jQuery and Bootstrap Upgrades #31
Applying npm for jQuery and Bootstrap Upgrades #31
Conversation
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
A few initial remarks. The browser console shows two HTTP errors 404:
I also see that a few older JavaScript files are found in the old Booststrap directory in <!-- Javascripts -->
<script src="/cgal-web/node_modules/jquery/dist/jquery.min.js"></script>
<script>window.jQuery || document.write('<script src="/cgal-web/node_modules/jquery/dist/jquery.min.js"><\/script>')</script>
<script src="/cgal-web/node_modules/bootstrap/dist/js/bootstrap.min.js"></script>
<script src="https://cgal.github.io/cgal-web/assets/themes/cgal/bootstrap/js/jquery.fitvids.js"></script>
<script src="https://cgal.github.io/cgal-web/assets/themes/cgal/bootstrap/js/jquery.sequence-min.js"></script>
<script src="https://cgal.github.io/cgal-web/assets/themes/cgal/bootstrap/js/jquery.bxslider.js"></script>
<script src="https://cgal.github.io/cgal-web/assets/themes/cgal/bootstrap/js/template.js"></script>
<script src="/cgal-web/node_modules/bootstrap-hover-dropdown/bootstrap-hover-dropdown.min.js"></script>
</body>
</html> That is probably a problem. |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
I think there is still work to do on |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
Here are a few things that need fixing:
|
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
That is a server setting. The server at https://www.cgal.org/ run Apache, and has the option |
That page was supposed to be removed by 99799d1. But the way we synchronized the web site with www.cgal.org does not remove files (we use |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
1 similar comment
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
@MaelRL @SaillantNicolas Let me know once you agree this PR is ready for merge. |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
The web-site is built. It will be available, after a few minutes, here: https://cgal.github.io/cgal-web/index.html |
Thanks @SaillantNicolas, and @MaelRL for the review and suggestions. I have merge the PR, to avoid any more copy-pasting errors. |
No description provided.