Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crocs_user_export): rewrite send script to python #788

Merged

Conversation

sarkapalkovicova
Copy link
Contributor

Send script for crocs_user_export was rewrote to python.

send/crocs_user_export.py Outdated Show resolved Hide resolved
send/crocs_user_export.py Outdated Show resolved Hide resolved
send/crocs_user_export.py Outdated Show resolved Hide resolved
send/crocs_user_export.py Outdated Show resolved Hide resolved
@sarkapalkovicova sarkapalkovicova force-pushed the crocs_user_export_python branch from b882759 to a3bffae Compare May 30, 2023 18:50
Copy link
Contributor

@xflord xflord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also please check with someone whether we want to keep the old send scripts or remove them and replace them with the new python ones. (the .py suffix might cause problems?)

Send script for crocs_user_export was rewrote to python.
@sarkapalkovicova sarkapalkovicova force-pushed the crocs_user_export_python branch from a3bffae to d3febdb Compare June 1, 2023 13:54
@sarkapalkovicova
Copy link
Contributor Author

Looks good. Also please check with someone whether we want to keep the old send scripts or remove them and replace them with the new python ones. (the .py suffix might cause problems?)

After discussion with @zlamalp, old script was replaced with new Python one.

@sarkapalkovicova sarkapalkovicova requested a review from zlamalp June 13, 2023 20:26
Copy link
Contributor

@zlamalp zlamalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in production, works.

@sarkapalkovicova sarkapalkovicova merged commit 4f658e2 into CESNET:master Jun 14, 2023
@github-actions
Copy link

🎉 This PR is included in version 7.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants