Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #3 #59

Merged
merged 3 commits into from
Nov 3, 2020
Merged

Fix for #3 #59

merged 3 commits into from
Nov 3, 2020

Conversation

ahouseholder
Copy link
Contributor

Attempting to fix #3. 2nd try, rebased onto latest main.

Note that this PR is built on PR #55 so either that one should be integrated first or, if both are acceptable this one will also fix #53 when merged.

Fixes #3, #53
Closes #55

@ahouseholder
Copy link
Contributor Author

This PR supersedes #56

@ahouseholder ahouseholder requested a review from j--- November 2, 2020 20:21
j---
j--- approved these changes Nov 3, 2020
View reviewed changes
Copy link
Collaborator

@j--- j--- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll note in #24 to update the xref in this paragraph.

@j--- j--- merged commit 25a4d3c into CERTCC:main Nov 3, 2020
@ahouseholder ahouseholder added this to the SSVC v2 milestone Nov 13, 2020
@ahouseholder ahouseholder deleted the feature/fix_3 branch January 14, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j--- j--- j--- approved these changes

Assignees

@j--- j---

Labels
None yet
Projects
None yet
Milestone
SSVC v2.0
2 participants
@ahouseholder @j---