-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add building block analogy explainer #447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahouseholder
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Feb 9, 2024
ahouseholder
requested review from
cgyarbrough,
sei-vsarvepalli and
j---
as code owners
February 9, 2024 15:41
j---
requested changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good! Just two questions.
# Conflicts: # docs/topics/index.md # mkdocs.yml
j---
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
docs/topics/decision_points_as_bricks.md
that explains the LEGO® bricks analogy we've been talking about for a while.docs/topics/enumerating_decisions.md
to clean up a few nitsWhen combined with the update to
topics/index.md
that appeared in #424, I believe this PR adequately addresses #296.Note: I checked the LEGO® trademark page to confirm that it's okay to mention the name as long as it's an adjective, not a noun, and include the disclaimer that appears in the offset box in the accompanying text:
I was also careful to limit the mentions of the trademark to the top of the doc, so if for some reason we needed to remove it we could do so with minimal effect on the rest of the page.