Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recreated CSV files and added a folder for them with readme; updated generation scripts #161

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

j---
Copy link
Collaborator

@j--- j--- commented Mar 15, 2022

contributes to #160

I used the PDFs in doc/graphics to type in the priority labels. Hopefully there are no typos in the priority labels -- I don't see any. The decision point combinations are programmatically generated using the enumerate*.sh scripts, so the names for the decision point values are consistent since the script creates those.

@j--- j--- self-assigned this Mar 15, 2022
@j--- j--- requested a review from sei-vsarvepalli March 15, 2022 20:18
@sei-vsarvepalli
Copy link
Contributor

sei-vsarvepalli commented Mar 15, 2022

There seems to be few folders in the shell scripts and python scripts.

"../data/deployer-options_v2.csv" in enumerate-deployer-options.sh
"../data/csvs/deployer-options_v2.csv" in enumerate-deployer-options.sh
"../data/v{1,2}/csv/" in the python scripts for v1 and v2 respectively

so we can standardize all to be "../data/csvs/" as you already have the _v2 or _v1 in the filename itself.

The output from shell scripts should also ideally has the final column also filled.

Vijay

@sei-vsarvepalli
Copy link
Contributor

A quick mockup of the script to be something like below - we could also generalize all of the filenames, version numbers to variables to avoid mistakes..

#!/bin/bash

# row numbers make change discussion a lot easier
i=1

# default output file in the SSVC Github file structure
out="../data/csvs/supplier-options_v2.csv"

# refuse to clobber existing file
if [ -e "$out" ] 
  then echo "File $out exists. Will not clobber. Exiting."
  exit 1
fi

#header row
decisions="Priority,defer,scheduled,defer,out-of-cycle,scheduled,out-of-cycle,scheduled,out-of-cycle,scheduled,out-of-cycle,scheduled,out-of-cycle,scheduled,out-of-cycle,scheduled,immediate,scheduled,immediate,out-of-cycle,immediate,out-of-cycle,immediate,out-of-cycle,immediate,out-of-cycle,immediate,out-of-cycle,immediate,out-of-cycle,immediate,out-of-cycle,immediate,immediate,immediate,immediate,immediate"
IFS=',' read -r -a decision <<< "$decisions"
echo "row,Exploitation,Utility,Technical Impact,Public-Safety Impact,${decision[0]}">$out
for Exploitation in none PoC active
  do for Utility in laborious efficient "super effective"
    do for Technical in partial total
      do for PublicSafety in minimal significant
          do echo $i,$Exploitation,$Utility,$Technical,$PublicSafety,${decision[i]}>>$out 
             i=$(($i+1))
      done
    done
  done
done

@sei-vsarvepalli sei-vsarvepalli merged commit e2a44f6 into CERTCC:main Mar 16, 2022
@j--- j--- deleted the restore-csvs branch March 16, 2022 20:50
@ahouseholder ahouseholder added this to the SSVC v2.1 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants