Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed virulence to automatable #156

Merged
merged 4 commits into from
Jan 5, 2022
Merged

changed virulence to automatable #156

merged 4 commits into from
Jan 5, 2022

Conversation

j---
Copy link
Collaborator

@j--- j--- commented Jan 4, 2022

No description provided.

@j--- j--- added the enhancement New feature or request label Jan 4, 2022
@j--- j--- requested a review from sei-vsarvepalli January 4, 2022 18:43
@sei-vsarvepalli
Copy link
Contributor

@j---

There is one problem with this "Yes" vs "yes" and "No" vs "no" - the mappings will fail unless they match exactly. I will suggest a fix after running a few tests.

https://github.com/j---/SSVC/blob/7521e33274b4de51ff471d7e4df92b47b096d0a8/data/schema_examples/CISA-Coordinator-v2.02.json#L31
https://github.com/j---/SSVC/blob/7521e33274b4de51ff471d7e4df92b47b096d0a8/data/schema_examples/CISA-Coordinator-v2.02.json#L278

https://github.com/j---/SSVC/blob/7521e33274b4de51ff471d7e4df92b47b096d0a8/data/schema_examples/CISA-Coordinator-v2.02.json#L36

https://github.com/j---/SSVC/blob/7521e33274b4de51ff471d7e4df92b47b096d0a8/data/schema_examples/CISA-Coordinator-v2.02.json#L278

Vijay

@sei-vsarvepalli
Copy link
Contributor

Requires a few more changes to adhere to our server requirements when a tree is updated. See more at
#112

sei-vsarvepalli
sei-vsarvepalli approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@sei-vsarvepalli sei-vsarvepalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay looks all clear for landing after some updates mostly to satisfy versioning concerns.

@sei-vsarvepalli sei-vsarvepalli merged commit 573a3c7 into CERTCC:main Jan 5, 2022
@ahouseholder ahouseholder added this to the SSVC v2.1 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sei-vsarvepalli sei-vsarvepalli sei-vsarvepalli approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
SSVC v2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@j--- @sei-vsarvepalli @ahouseholder