Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on passing execute field to karton #904

Merged
merged 14 commits into from
Feb 1, 2024
Merged

Conversation

msm-cert
Copy link
Member

@msm-cert msm-cert commented Jan 31, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?
There is no way to submit a file and pass an atribute to karton

What is the new behaviour?
Attributes passed in the request directly, and some file attributes are passed to the karton analysis.

There is a special attribute called execute which gets passed to the karton pipeline. In the future, this may be a property of mwdb attribute definition.

@msm-cert msm-cert requested a review from psrok1 January 31, 2024 17:09
Copy link
Member

@psrok1 psrok1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should somehow filter the arguments as they're passed directly to headers. Someone may overwrite critical fields like type, kind or stage 🤔

mwdb/core/karton.py Outdated Show resolved Hide resolved
Copy link
Member

@psrok1 psrok1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make ALLOWED_HEADERS global to make it extendable by plugins but ideally it should be defined in schema 🤔 Looks good for now, possibly to be extended in next steps.

@psrok1 psrok1 merged commit ee5cb12 into master Feb 1, 2024
12 checks passed
@psrok1 psrok1 deleted the feature/no-execute-field branch February 1, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants