-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work on passing execute field to karton #904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should somehow filter the arguments as they're passed directly to headers. Someone may overwrite critical fields like type
, kind
or stage
🤔
Co-authored-by: Paweł Srokosz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make ALLOWED_HEADERS
global to make it extendable by plugins but ideally it should be defined in schema 🤔 Looks good for now, possibly to be extended in next steps.
Your checklist for this pull request
What is the current behaviour?
There is no way to submit a file and pass an atribute to karton
What is the new behaviour?
Attributes passed in the request directly, and some file attributes are passed to the karton analysis.
There is a special attribute called
execute
which gets passed to the karton pipeline. In the future, this may be a property of mwdb attribute definition.