Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drakrun: Attach profiles to analyses #504

Merged
merged 20 commits into from
Apr 23, 2021
Merged

drakrun: Attach profiles to analyses #504

merged 20 commits into from
Apr 23, 2021

Conversation

chivay
Copy link
Collaborator

@chivay chivay commented Apr 12, 2021 •
edited
Loading

closes #463

  • Send profiles with task
  • Define new profiles
  • Make attaching configurable
  • Create required profiles on postupgrade

@chivay chivay marked this pull request as ready for review April 19, 2021 12:36
BonusPlay
BonusPlay reviewed Apr 19, 2021
View reviewed changes
drakrun/drakrun/draksetup.py Show resolved Hide resolved
drakrun/drakrun/draksetup.py Show resolved Hide resolved
drakrun/drakrun/draksetup.py Show resolved Hide resolved
drakrun/drakrun/draksetup.py Show resolved Hide resolved
chivay
chivay commented Apr 20, 2021
View reviewed changes
drakrun/drakrun/main.py Outdated Show resolved Hide resolved
@chivay chivay requested a review from icedevml April 20, 2021 10:50
@chivay
Copy link
Collaborator Author

chivay commented Apr 20, 2021

I've bumped the CI snapshot to contain more usermode profiles. However there are some of them that cause issues:

Still failing:

  • Windows/System32/ole32.dll
  • Windows/SysWOW64/ole32.dll
  • Windows/System32/combase.dll
  • Windows/Microsoft.NET/Framework/v4.0.30319/clr.dll - we can ignore this as there's not .NET installed on the CI machine
  • Windows/System32/urlmon.dll
  • Windows/SysWOW64/urlmon.dll

@manorit2001
Copy link
Contributor

  • Windows/System32/ole32.dll
  • Windows/SysWOW64/ole32.dll
  • Windows/System32/combase.dll

I have seen these three fail before this PR also

@chivay
Copy link
Collaborator Author

chivay commented Apr 20, 2021

Let's see if bumping pdbparse will help

@chivay
Copy link
Collaborator Author

chivay commented Apr 20, 2021

well, and it didn't help 🤔

@chivay chivay force-pushed the task-rvas branch 4 times, most recently from eaea99d to ac3c214 Compare April 21, 2021 12:58
@chivay chivay merged commit 3ac6cf2 into master Apr 23, 2021
@chivay chivay deleted the task-rvas branch April 23, 2021 12:30
@catsuryuu catsuryuu mentioned this pull request Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manorit2001 manorit2001 manorit2001 left review comments

@BonusPlay BonusPlay BonusPlay left review comments

@icedevml icedevml icedevml approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RVAs of apicalls
4 participants
@chivay @manorit2001 @icedevml @BonusPlay