Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Use GitHub Actions #658

Merged
merged 8 commits into from
Nov 9, 2020
Merged

CI - Use GitHub Actions #658

merged 8 commits into from
Nov 9, 2020

Conversation

jeremylt
Copy link
Member

@jeremylt jeremylt commented Nov 6, 2020

This PR shifts our CI to GitHub actions and increases the testing on Noether.

Closes #652

ToDo:

  • Migrate Julia docs build to GitHub Actions
  • Fix filepath error for Nek5000 on Noether
  • Drop Travis requirement in repo settings

@jeremylt jeremylt self-assigned this Nov 6, 2020
@jeremylt jeremylt force-pushed the jeremy/actions branch 2 times, most recently from e834905 to eaed15a Compare November 6, 2020 18:23
@jeremylt
Copy link
Member Author

jeremylt commented Nov 6, 2020

OK, I have:

GitHub Actions

  • Test [gcc-9, clang] on [ubuntu, osx]
  • Test [gcc-9] on [ubuntu] with [aarch64, ppc64le]
  • Test [icc and ifort] on [ubuntu]
  • Test style
  • Test Python with style
  • Test Julia with style

GitLab CI

  • Test [hipMAGMA, LIBXSMM, OCCA, Valgrind] backends with [MFEM, Nek5000]
  • CodeCov

Azure Pipelines

  • Test base libCEED with PETSc

The big open ToDos are

  • update the Julia documentation deployment, but that has to be @pazner because it involves setting up keys
  • Noether filepaths too long for Nek5000
  • strange bug with building Nek examples on Noether (not reproducing manually)

Also, I'd like to investigate ICC testing on GitHub Actions.

@jeremylt
Copy link
Member Author

jeremylt commented Nov 6, 2020

@jedbrown, the only reason Noether is failing is because the filepath is too long for the Nek5000 qFunctions. Is there a way to cut down the length of the filepath for these jobs?

We'll also need to remove Travis CI as a 'required' for PRs

@jeremylt jeremylt force-pushed the jeremy/actions branch 12 times, most recently from 5284cad to 3a34c5a Compare November 6, 2020 21:40
@jeremylt jeremylt requested review from jedbrown and pazner November 6, 2020 21:49
@jeremylt jeremylt force-pushed the jeremy/actions branch 9 times, most recently from 42817f9 to c40b623 Compare November 7, 2020 20:08
@pazner
Copy link
Member

pazner commented Nov 7, 2020

GitLab CI passes now. Just need to sort out the Julia keys

I've got most of this set up on my end, but I don't have access to add secrets keys for GitHub actions.

@jeremylt jeremylt force-pushed the jeremy/actions branch 3 times, most recently from 17030e1 to 5e87aa8 Compare November 7, 2020 21:07
@pazner
Copy link
Member

pazner commented Nov 9, 2020

I think the Julia documentation is good to go. There is an option to publish "preview" documentation for PRs that is currently disabled. Do we want to enable that?

Let me know if there are other changes I should make.

@jedbrown
Copy link
Member

jedbrown commented Nov 9, 2020

Are the previews linked from the PRs? We use that for ReadTheDocs and I think it's quite useful for review. I'd expect only a modest fraction of PRs will touch Julia docs, but I don't see that as a problem.

@pazner
Copy link
Member

pazner commented Nov 9, 2020

Are the previews linked from the PRs? We use that for ReadTheDocs and I think it's quite useful for review. I'd expect only a modest fraction of PRs will touch Julia docs, but I don't see that as a problem.

The preview will be associated with the PR number. I don't think a link from the PR will automatically be created (e.g. as a comment, like codecov. Something like this is probably possible using actions, though). I'm not sure if that's what you are referring to.

@jeremylt
Copy link
Member Author

jeremylt commented Nov 9, 2020

I have a mild preference to put both Julia jobs in the same file, but whichever seems more readable works for me

@pazner
Copy link
Member

pazner commented Nov 9, 2020

I enabled the previews. For example, for this PR the docs can be found at https://ceed.exascaleproject.org/libCEED-julia-docs/previews/PR658/

@jeremylt, I can squash the Julia commits or would you prefer to do it?

@pazner
Copy link
Member

pazner commented Nov 9, 2020

I have a mild preference to put both Julia jobs in the same file, but whichever seems more readable works for me

I had them in the same file, but I just separated them because the triggers are not the same.

@jeremylt
Copy link
Member Author

jeremylt commented Nov 9, 2020

Feel free to squash as you like

@jeremylt
Copy link
Member Author

jeremylt commented Nov 9, 2020

I squashed some of my commits as well. I think we are ready to drop the Travis requirement in the repo settings and merge this PR.

@jeremylt jeremylt mentioned this pull request Nov 9, 2020
@jedbrown
Copy link
Member

jedbrown commented Nov 9, 2020

I think I have the required jobs set appropriately now. It seems the GitLab-CI pipelines include the branch name so I don't know how to make it required.

@jeremylt jeremylt merged commit 98e77aa into main Nov 9, 2020
@jeremylt jeremylt deleted the jeremy/actions branch November 9, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate Travis or move CI away
3 participants