-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI - Use GitHub Actions #658
Conversation
e834905
to
eaed15a
Compare
OK, I have: GitHub Actions
GitLab CI
Azure Pipelines
The big open ToDos are
|
@jedbrown, the only reason Noether is failing is because the filepath is too long for the Nek5000 qFunctions. Is there a way to cut down the length of the filepath for these jobs? We'll also need to remove Travis CI as a 'required' for PRs |
5284cad
to
3a34c5a
Compare
42817f9
to
c40b623
Compare
I've got most of this set up on my end, but I don't have access to add secrets keys for GitHub actions. |
17030e1
to
5e87aa8
Compare
I think the Julia documentation is good to go. There is an option to publish "preview" documentation for PRs that is currently disabled. Do we want to enable that? Let me know if there are other changes I should make. |
Are the previews linked from the PRs? We use that for ReadTheDocs and I think it's quite useful for review. I'd expect only a modest fraction of PRs will touch Julia docs, but I don't see that as a problem. |
The preview will be associated with the PR number. I don't think a link from the PR will automatically be created (e.g. as a comment, like codecov. Something like this is probably possible using actions, though). I'm not sure if that's what you are referring to. |
I have a mild preference to put both Julia jobs in the same file, but whichever seems more readable works for me |
I enabled the previews. For example, for this PR the docs can be found at https://ceed.exascaleproject.org/libCEED-julia-docs/previews/PR658/ @jeremylt, I can squash the Julia commits or would you prefer to do it? |
I had them in the same file, but I just separated them because the triggers are not the same. |
Feel free to squash as you like |
ad67152
to
523ddde
Compare
523ddde
to
97e6062
Compare
I squashed some of my commits as well. I think we are ready to drop the Travis requirement in the repo settings and merge this PR. |
97e6062
to
cf0e96f
Compare
I think I have the required jobs set appropriately now. It seems the GitLab-CI pipelines include the branch name so I don't know how to make it required. |
This PR shifts our CI to GitHub actions and increases the testing on Noether.
Closes #652
ToDo: