Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VADR Patch + FASTA Enhancement (Issue #116 / Issue #82) #118

Merged
merged 23 commits into from
Jan 9, 2024

Conversation

ankushkgupta2
Copy link
Contributor

Description

Please Describe the Bug(s) Fixed and/or the Feature(s) Added:
Patch to make VADR fully functional and enhance functionality for FASTA expectations overall.

Checklist

Go Through Checklist Below and Place A ✔️ (X Inside the Box) if Completed

General Checks

  • Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out?
    • Does it produce the expected outputs, given the inputs provided?
  • Have you conducted proper linting procedures?

    • Numpy formatted docstrings for functions
    • Comments explaining lines of code
    • Consistent and intuitive naming conventions for variables, functions, classes, methods, attributes, and scripts
    • Single empty line between class functions, two lines between non-class functions, and two lines between imports and code body
    • Camel case formatting for class names
  • Have you updated existing documentation (README.md, etc.) or created new ones within docs?

CDC Checks

  • Did you check for sensitive data, and remove any?
  • If you added or modified HTML, did you check that it was 508 compliant?

Are additional approvals needed for this change? If so, please mention them below:
No.

Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below:
No.

…outside of it. include statement changed to reflect this
@ankushkgupta2 ankushkgupta2 self-assigned this Jan 9, 2024
@ankushkgupta2 ankushkgupta2 merged commit 631e03d into dev Jan 9, 2024
1 check failed
@ankushkgupta2 ankushkgupta2 deleted the 116-internal-vadr-fasta-patch branch January 9, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant