Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bob/fix mutation error states #6437

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Bob/fix mutation error states #6437

merged 2 commits into from
Aug 29, 2023

Conversation

fzhao99
Copy link
Contributor

@fzhao99 fzhao99 commented Aug 28, 2023 •
edited
Loading

BACKEND PULL REQUEST

Related Issue

  • Fixing some error state handling as mentioned in this comment

Changes Proposed

  • Moves error handling logic out of the resolver so things get thrown more descriptively.

Testing

Deployed in dev 2

Try mutating with

  • accessAllFacility=false and an empty facility array
  • A facility array with a UUID that isn't in the org (using something like https://www.uuidgenerator.net/)
  • A bad user name

Each one should throw with a custom error message.

screen-recording-2023-08-28-at-30732-pm_A2lTzICe.mp4

@fzhao99 fzhao99 temporarily deployed to Dev2 August 28, 2023 17:44 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@fzhao99 fzhao99 marked this pull request as ready for review August 28, 2023 19:05
BobanL
BobanL approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the error messages!

@fzhao99 fzhao99 enabled auto-merge August 29, 2023 15:13
emyl3
emyl3 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fzhao99 fzhao99 added this pull request to the merge queue Aug 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2023
@fzhao99 fzhao99 added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit e03891c Aug 29, 2023
@fzhao99 fzhao99 deleted the bob/fix-mutation-error-states branch August 29, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyl3 emyl3 emyl3 approved these changes

@BobanL BobanL BobanL approved these changes

@mehansen mehansen Awaiting requested review from mehansen

@johanna-skylight johanna-skylight Awaiting requested review from johanna-skylight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fzhao99 @BobanL @emyl3