Fix facilities dropdown #6030
Merged
Fix facilities dropdown #6030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobanL
previously approved these changes
Jun 23, 2023
|
fixing some e2e issues that were introduced with this fix 😅 |
emyl3
force-pushed
the
elisa/fix-facility-dropdown
branch
from
8455edd to
eb26331
Compare
emyl3
commented
Jun 27, 2023
| @@ -362,7 +363,7 @@ const FacilityForm: React.FC<Props> = (props) => { | |||
| className="margin-right-0 margin-top-05" | |||
| type="submit" | |||
| label="Save changes" | |||
| disabled={isSubmitting || !isDirty} | |||
There was a problem hiding this comment.
this wasn't actually setting the save button to be disabled when we click the "Save changes" button. isSubmitted would do that but there's an issue if you back out of the address confirmation modal -- it won't reactivate the "Save changes" button so I opted to remove this.
|
Ready for re-review! Thank you for your patience 😅 🙏 |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FRONTEND PULL REQUEST
Related Issue
After the changes introduced in #5983, facilities in the dropdown were not being properly updated.
Changes Proposed
Fix the facilities dropdown in the header to update the facility names correctly when they are updated or added.
Additional Information
please let me know if there's a good way to add test coverage for this scenario 🤔
Testing
on dev5 for testing
Screenshots / Demos