Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Johanna/small clean up frontend tests #5950

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

johanna-skylight
Copy link
Contributor

@johanna-skylight johanna-skylight commented Jun 9, 2023

FRONTEND PULL REQUEST

Related Issue

No ticket

Changes Proposed

This is a partial clean up of the act warnings. These warnings are polluting our unit testing logs to the point that we are ignoring the actual useful warnings like DOM elements incorrectly structure and mocks missing.

Testing

Unit testing for the frontend should pass.

Copy link
Contributor

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to make running the tests way better! Thank you 🤠

Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup 🧹

@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants