[Main menu - Site Admin] account menu item role should be button and collapse attribute properly populated

[johanna-skylight]

Area or Component

Main navigation menu with a site admin role.

Quick Summary

The account button, which upon clicking displays a submenu, has a role of link and no collapsible aria attribute.

How to Replicate

Check the DOM.

Accessibility Violation

The element's role is missing or is not appropriate for the element's function.

The element has missing or incorrect states or properties that are necessary for screen reader users to interact with or understand the content conveyed by the element.

Action Requested

Set the role to button
Add aria-collapse = true/false depending the state of the submenu.

Screenshots (optional)

[johanna-skylight]

@mehansen the settings button is also displaying even though it does nothing for this role. Let me know if you want me to add the removal of that button as part of the a/c of the ticket.

[mehansen]

@mehansen the settings button is also displaying even though it does nothing for this role. Let me know if you want me to add the removal of that button as part of the a/c of the ticket.

thanks for the callout @johanna-skylight I'm leaning towards leaving this alone but let's bring it up when we refine this ticket. I think it might make sense to at least make design aware so they can consider that in any future header designs

[mehansen]

@ whoever takes this ticket: please reach out to design and let them know, but it's not an accessibility violation and we don't have any bugs around this, so no need to hold up resolving this ticket over this. if necessary we can make a followup design fix ticket

[emyl3]

#6410 (comment)
this part is done :) https://skylight-hq.slack.com/archives/C039689GS4S/p1694012183896279