Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [DEV-9931] Adjust color palette settings on maps #1718

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

adamdoe
Copy link
Collaborator

@adamdoe adamdoe commented Nov 25, 2024

[DEV-9931] Adjust color palette settings on maps

Prior to this release custom color palettes were using the color distributions array which was confusing folks. For example if users had a legend with three items they would need to enter ['red', 'red', 'yellow', 'yellow', 'orange', 'orange'] as a workaround to achieve red, yellow, and orange since thats how the color distribution matrix picks our sandard colors. This also moves the ts file out of CdcMap and fixes issues with calculating special class colors. See testing steps for more info.

Testing Steps

  • Run yarn storybook
  • Open story/components-templates-map--custom-color-distributions-with-special-classes
  • Verify red ,orange, yellow custom color scheme
  • Open /story/components-templates-map--custom-color-distributions-without-special-classes
  • Verify custom colors are red, orange, yellow color scheme with single special class
  • Open /story/components-templates-map--standard-color-distributions-with-special-classes
  • Verify STANDARD yelloworangered palette inside of the config using color distributions with the special
  • Open /story/components-templates-map--standard-color-distributions-without-special-classes
  • Verify STANDARD yelloworangered palette inside of the config using color distributions without the special class
  • Open story/components-templates-map--custom-color-distributions-with-update-needed to verify color schemes implemented before 4.24.12 (skips red, yellow, blue) in ROYGBIV

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Additional Notes

@adamdoe adamdoe added this to the 4.24.12 milestone Nov 25, 2024
@adamdoe adamdoe changed the title [DEV-9931] Adjust color palette settings on maps Fix: [DEV-9931] Adjust color palette settings on maps Nov 26, 2024
Copy link
Collaborator

@Mgetz10 Mgetz10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much more intuitive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants