Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New figure 1 function #375

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Conversation

SamuelBrand1
Copy link
Collaborator

This is a small PR which modifies the figure 1 generation to meet discussion points in #370 (and elsewhere). The new generation script generates a figure for each latent model choice (one to be used in main ms and others for SI).

Close #374

@SamuelBrand1 SamuelBrand1 requested a review from seabbs July 17, 2024 09:40
@SamuelBrand1 SamuelBrand1 linked an issue Jul 17, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.09%. Comparing base (717f586) to head (112b91c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files          50       50           
  Lines         521      521           
=======================================
  Hits          485      485           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

seabbs
seabbs previously approved these changes Jul 17, 2024
Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks good. I am a bit surprised you've needed to make subplots and compose vs using AlgebraofGraphics facet mechanics (which is what I would do if making this in ggplot2 for example.

What do you think about moving the legend to below the plot vs on the side?

@SamuelBrand1
Copy link
Collaborator Author

Nice looks good. I am a bit surprised you've needed to make subplots and compose vs using AlgebraofGraphics facet mechanics (which is what I would do if making this in ggplot2 for example.

My problem here was that I/search engines couldn't work out how to vary the ylims figure by figure... I'm being a bit basic here I think. I agree because unlike the first pass fig 1 now the subplots are slightly different sized.

@SamuelBrand1
Copy link
Collaborator Author

I forgot the reference date indication (mentioned by @seabbs f2f)! Added now.

This now closes #377

@SamuelBrand1 SamuelBrand1 requested a review from seabbs July 17, 2024 15:12
@seabbs
Copy link
Collaborator

seabbs commented Jul 17, 2024

Can you do it by specifying it as a variable in the data? I think that would be the ggplot2 solution?

@seabbs seabbs enabled auto-merge July 17, 2024 16:32
@seabbs seabbs added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit cc13bad Jul 17, 2024
10 checks passed
@seabbs seabbs deleted the 374-modify-fig1-to-split-between-main-and-si-figs branch July 17, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify Fig1 to split between main and SI figs
3 participants