-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New figure 1 function #375
New figure 1 function #375
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
=======================================
Coverage 93.09% 93.09%
=======================================
Files 50 50
Lines 521 521
=======================================
Hits 485 485
Misses 36 36 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice looks good. I am a bit surprised you've needed to make subplots and compose vs using AlgebraofGraphics
facet mechanics (which is what I would do if making this in ggplot2
for example.
What do you think about moving the legend to below the plot vs on the side?
My problem here was that I/search engines couldn't work out how to vary the ylims figure by figure... I'm being a bit basic here I think. I agree because unlike the first pass fig 1 now the subplots are slightly different sized. |
Can you do it by specifying it as a variable in the data? I think that would be the ggplot2 solution? |
This is a small PR which modifies the figure 1 generation to meet discussion points in #370 (and elsewhere). The new generation script generates a figure for each latent model choice (one to be used in main ms and others for SI).
Close #374