Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

231 write sphinx documentation using markdown via myst #457

Merged

Conversation

dylanhmorris
Copy link
Collaborator

@dylanhmorris dylanhmorris commented Sep 24, 2024

This PR:

Closes #231

@dylanhmorris dylanhmorris linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.41%. Comparing base (9bc3dae) to head (3a3a566).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #457   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files          42       42           
  Lines        1003     1003           
=======================================
  Hits          947      947           
  Misses         56       56           
Flag Coverage Δ
unittests 94.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dylanhmorris dylanhmorris marked this pull request as ready for review September 26, 2024 18:45
@dylanhmorris
Copy link
Collaborator Author

As of ac5ac13 this will also close #414

@dylanhmorris dylanhmorris linked an issue Sep 28, 2024 that may be closed by this pull request
@dylanhmorris
Copy link
Collaborator Author

This should also resolve #413

Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dylanhmorris. I think a bit more cleanup could be done before or after merging this. See my comments.

@dylanhmorris
Copy link
Collaborator Author

Thanks @dylanhmorris. I think a but more cleanup could be done before or after mergin this. See my comments.

I think after makes sense for atomicity

@dylanhmorris dylanhmorris merged commit 907d1c1 into main Sep 29, 2024
8 checks passed
@dylanhmorris dylanhmorris deleted the 231-write-sphinx-documentation-using-markdown-via-myst branch September 29, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants