-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworks InitializeInfectionsExponentialGrowth
to work with numpyro.plate
#432
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
- Coverage 93.53% 93.51% -0.02%
==========================================
Files 41 41
Lines 1021 1018 -3
==========================================
- Hits 955 952 -3
Misses 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@dylanhmorris @sbidari docs are not rendering. The problem is that the shape of the output of the initialization method for a non-plated context has changed from |
Is there a reason not to use |
@dylanhmorris that could be a good fix for the current demo models, but I think we need a more thorough exploration of multiple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the content of the change, could we have tests both for the case in which rate
is a scalar and for the case in which it is an array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tests could probably be DRY-ified via pytest.mark.parametrize
but that can be a separate PR.
I thought about that, but the logic to determine the manual computations seemed nearly as verbose as the fully manual solution, while being less readable. |
No description provided.