Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify README With Instantiated Model Information #430

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

AFg6K7h4fhy2
Copy link
Collaborator

PR for

There are PyRenew models that now exist in external repositories and, while referenced in Issues and PRs, it also makes sense to clearly indicate where these models exist. The author's expectation is that some people might go to this repository first, when looking for any of the PyRenew-dependent repositories, and not readily be able to find these external PyRenew models.

@AFg6K7h4fhy2 AFg6K7h4fhy2 added the documentation Improvements or additions to documentation label Sep 5, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 added this to the R Sprint milestone Sep 5, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 self-assigned this Sep 5, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 linked an issue Sep 5, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (fd9e49e) to head (2a1c131).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          41       41           
  Lines        1021     1021           
=======================================
  Hits          955      955           
  Misses         66       66           
Flag Coverage Δ
unittests 93.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AFg6K7h4fhy2! Let me know what you think of my suggestion.

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to @damonbayer's comment. I'm not sure it makes sense to call flulight "an Epidemia model"; could go with "previously implemented in Epidemia"?

README.md Outdated Show resolved Hide resolved
@damonbayer damonbayer self-requested a review September 5, 2024 16:35
@damonbayer damonbayer merged commit adf5aaf into main Sep 5, 2024
8 checks passed
@damonbayer damonbayer deleted the 429-edit-readme-to-include-instantiated-models branch September 5, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit README To Include Instantiated Models
3 participants