-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create randomvariable
module
#412
Conversation
…rence into 385-incorrect-convolve-mode-in-hospitaladmissionspy
…orrect-convolve-mode-in-hospitaladmissionspy
…orrect-convolve-mode-in-hospitaladmissionspy
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
+ Coverage 93.45% 93.52% +0.06%
==========================================
Files 38 41 +3
Lines 1009 1019 +10
==========================================
+ Hits 943 953 +10
Misses 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@dylanhmorris @sbidari Do we need to make any changes about what is in the |
Potentially move |
We agreed not to move the |
@sbidari is this ready for review? |
…te_randomvariable_module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the merge undid some changes from #356.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sbidari!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My approval was premature. The randomvariable
module documentation needs to be added to the website.
DistributionalRV
andTransformedRandomVariable
frommetaclass
torandomvariable
module,DistributionalRV
->DistributionalVariable
StaticDistributionalRV
->StaticDistributionalVariable
DynamicDistributionalRV
->DynamicDistributionalVariable
TransformedRandomVariable
->TransformedVariable
closes #392