Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create randomvariable module #412

Merged
merged 24 commits into from
Aug 26, 2024
Merged

Conversation

sbidari
Copy link
Collaborator

@sbidari sbidari commented Aug 22, 2024

  • moves DistributionalRV and TransformedRandomVariable from metaclass to randomvariable module,
  • renames
    • DistributionalRV -> DistributionalVariable
    • StaticDistributionalRV -> StaticDistributionalVariable
    • DynamicDistributionalRV -> DynamicDistributionalVariable
    • TransformedRandomVariable -> TransformedVariable

closes #392

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 97.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.52%. Comparing base (1a86104) to head (b6ea3d5).
Report is 1 commits behind head on main.

Files Patch % Lines
pyrenew/randomvariable/distributionalvariable.py 95.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   93.45%   93.52%   +0.06%     
==========================================
  Files          38       41       +3     
  Lines        1009     1019      +10     
==========================================
+ Hits          943      953      +10     
  Misses         66       66              
Flag Coverage Δ
unittests 93.52% <97.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damonbayer
Copy link
Collaborator

@dylanhmorris @sbidari Do we need to make any changes about what is in the deterministic module?

@sbidari
Copy link
Collaborator Author

sbidari commented Aug 22, 2024

@dylanhmorris @sbidari Do we need to make any changes about what is in the deterministic module?

Potentially move DeterministicVariable to the randomvariable module? @dylanhmorris mentioned it in the issue comment.
But since DeterministicVariables are not really random variables, it might make more sense to leave them in the deterministic module?

@damonbayer
Copy link
Collaborator

We agreed not to move the DeterministicVariable class at this time.

@dylanhmorris
Copy link
Collaborator

@sbidari is this ready for review?

@damonbayer damonbayer self-requested a review August 23, 2024 15:01
@sbidari
Copy link
Collaborator Author

sbidari commented Aug 23, 2024

@sbidari is this ready for review?

Waiting for #356, I unintentionally created this branch with changes from #356

@damonbayer
Copy link
Collaborator

@sbidari #356 is merged. Please mark this as "ready for review" when it's ready for review.

@sbidari sbidari marked this pull request as ready for review August 26, 2024 16:50
pyrenew/metaclass.py Outdated Show resolved Hide resolved
@damonbayer damonbayer self-requested a review August 26, 2024 17:32
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the merge undid some changes from #356.

Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbidari!

@damonbayer damonbayer self-requested a review August 26, 2024 18:17
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval was premature. The randomvariable module documentation needs to be added to the website.

@damonbayer damonbayer self-requested a review August 26, 2024 19:16
@damonbayer damonbayer merged commit 79706e9 into main Aug 26, 2024
6 checks passed
@damonbayer damonbayer deleted the sb_create_randomvariable_module branch August 26, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

randomvariable module
3 participants