Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the initial GL2PS feedback buffer size. #1016

Merged
merged 3 commits into from
Feb 12, 2015

Conversation

alliepiper
Copy link
Contributor

To prevent having to resize and rerender multiple times when a very large
amount of data is pushed through (see #517), start with a 50MB buffer.

This buffer size is sufficient to store the 1M triangles used in the #517
example.

@doutriaux1 @aashish24

To prevent having to resize and rerender multiple times when a very large
amount of data is pushed through (see #517), start with a 50MB buffer.

This buffer size is sufficient to store the 1M triangles used in the #517
example.
@alliepiper alliepiper mentioned this pull request Feb 9, 2015
@aashish24
Copy link
Contributor

LGTM but lets @doutriaux1 approve it as well.

Since each layer is stored in a separate renderer, sorting is not
needed and is causing issues wrt numeric stability when loads of data is
pushed through.
@doutriaux1
Copy link
Contributor

@dlonie
I get this, using a full build (i.e Paraview vs VTK) could that be the issue?

/usr/local/uvcdat/2015-02-09/lib/python2.7/site-packages/vcs/VTKPlots.pyc in vectorGraphics(self, output_type, file, width, height, units)
   1341     # GL2PS info: OpenGL feedback buffer overflow
   1342     # increase it to save some time.
-> 1343     gl.SetBufferSize(50*1024*1024) # 50MB
   1344 
   1345     # Since the vcs layer stacks renderers to manually order primitives, sorting

AttributeError: SetBufferSize

@doutriaux1
Copy link
Contributor

In [10]: v.GetVTKVersion()
Out[10]: '6.2.0'

@alliepiper
Copy link
Contributor Author

Yes -- this patch is only in the VTK uvcdat-master.

@aashish24, what is our strategy for syncing paraview and VTK?

@aashish24
Copy link
Contributor

@dlonie I have updated the VTK in UV-CDAT/VTK. I just pushed the latest VTK with one extra commit on top.

@aashish24
Copy link
Contributor

@doutriaux1 make sure that you force rebuild VTK.

@alliepiper
Copy link
Contributor Author

@aashish24 What about FULL builds with ParaView, though? How do we get these changes in there?

@doutriaux1
Copy link
Contributor

@aashish24 @dlonie is right the issue is that these change seem to not be present when building ParaView. Can we have UV-CDAT's Paraview point to the same uvcdat-master tag point of UV-CDAT's VTK

@aashish24
Copy link
Contributor

@doutriaux1 yes but ParaView is mostly behind. I would have to check on the SHA its using.

Do you want to wait for that? I think most of us are using VTK so I prefer we merge it right now but I don't have strong feelings about it.

@doutriaux1
Copy link
Contributor

most of you are using default, but most of my users come down to my office if i accidentally build the default one. And Curt who reported this bug first is one of them. Why can't we update ParaView's VTK?

@doutriaux1
Copy link
Contributor

I saw your email. Building from scratch now, will get back to you.

@doutriaux1
Copy link
Contributor

@aashish24 ok now the whole ParaView is broken... I guess I will put a try/xcept around this so it works even with PAraView.
Can you please revert ParaView tag point. Thanks,

From git://vtk.org/VTK
   cdb450f..e4a03fa  master     -> origin/master
fatal: reference is not a tree: aa7eeca6abbb25d4a76e81028b10de24d0e6f6a8
Unable to checkout 'aa7eeca6abbb25d4a76e81028b10de24d0e6f6a8' in submodule path 'VTK'

I guess my question is why is it checking out VTK at VTK.org and not from us?

doutriaux1 added a commit that referenced this pull request Feb 12, 2015
Increase the initial GL2PS feedback buffer size.
@doutriaux1 doutriaux1 merged commit c184be3 into master Feb 12, 2015
@aashish24
Copy link
Contributor

@doutriaux1 sorry, I had one commit there left by mistake. Try it now. We cannot use our VTK since the URL would be diffirent and then also we have to make sure that it is compabille with ParaView.

@doutriaux1 doutriaux1 deleted the vector-graphics-buffer-size branch March 9, 2015 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants