-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the initial GL2PS feedback buffer size. #1016
Conversation
LGTM but lets @doutriaux1 approve it as well. |
Since each layer is stored in a separate renderer, sorting is not needed and is causing issues wrt numeric stability when loads of data is pushed through.
@dlonie
|
|
Yes -- this patch is only in the VTK uvcdat-master. @aashish24, what is our strategy for syncing paraview and VTK? |
@dlonie I have updated the VTK in UV-CDAT/VTK. I just pushed the latest VTK with one extra commit on top. |
@doutriaux1 make sure that you force rebuild VTK. |
@aashish24 What about FULL builds with ParaView, though? How do we get these changes in there? |
@aashish24 @dlonie is right the issue is that these change seem to not be present when building ParaView. Can we have UV-CDAT's Paraview point to the same uvcdat-master tag point of UV-CDAT's VTK |
@doutriaux1 yes but ParaView is mostly behind. I would have to check on the SHA its using. Do you want to wait for that? I think most of us are using VTK so I prefer we merge it right now but I don't have strong feelings about it. |
most of you are using default, but most of my users come down to my office if i accidentally build the default one. And Curt who reported this bug first is one of them. Why can't we update ParaView's VTK? |
I saw your email. Building from scratch now, will get back to you. |
@aashish24 ok now the whole ParaView is broken... I guess I will put a try/xcept around this so it works even with PAraView.
I guess my question is why is it checking out VTK at VTK.org and not from us? |
Increase the initial GL2PS feedback buffer size.
@doutriaux1 sorry, I had one commit there left by mistake. Try it now. We cannot use our VTK since the URL would be diffirent and then also we have to make sure that it is compabille with ParaView. |
To prevent having to resize and rerender multiple times when a very large
amount of data is pushed through (see #517), start with a 50MB buffer.
This buffer size is sufficient to store the 1M triangles used in the #517
example.
@doutriaux1 @aashish24