Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Make sure integer data arrays can be coregistered #775

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Conversation

JanisGailis
Copy link
Member

@JanisGailis JanisGailis commented Sep 27, 2018

There was a numba typing issue in the 'gridtools' code we had
incorporated, that would prevent the downsampling code from
compiling if a non-float datatype is used. Fix borrowed from upstream.

Closes #770

There was a numba typing issue in the 'gridtools' code we had
incorporated, that would prevent the downsampling code from
compiling if a non-float datatype is used. Fix borrowed from upstream.

#Closes 770
@JanisGailis JanisGailis requested a review from forman September 27, 2018 11:34
@JanisGailis
Copy link
Member Author

JanisGailis commented Sep 27, 2018

This is why we should really switch to using upstream 'gridtools' :)

esa-esdl/gridtools@e27bc96

@forman Another note. Do you think we should prevent the users from running coregistration with resampling methods that are not suited for int and bool datatypes, by determining this and raising a ValidationError and suggesting to either select_var or choose a method that makes sense? I myself am on the fence about this one.

EDIT: As usual, I'll merge this in a day, if you won't have found time to attend this!

@codecov-io
Copy link

codecov-io commented Sep 27, 2018

Codecov Report

Merging #775 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
- Coverage   76.65%   76.64%   -0.01%     
==========================================
  Files          82       82              
  Lines       12730    12730              
==========================================
- Hits         9758     9757       -1     
- Misses       2972     2973       +1
Impacted Files Coverage Δ
cate/ops/resampling.py 95.66% <100%> (ø) ⬆️
cate/util/process.py 90.15% <0%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3762653...c52f7a0. Read the comment docs.

@JanisGailis JanisGailis merged commit aee8e08 into master Sep 28, 2018
@JanisGailis
Copy link
Member Author

Merged as promised :)

@JanisGailis JanisGailis deleted the jg-770-coreg branch September 28, 2018 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants