This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Jg 585 animation error #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 18, 2018 17:29
We apparently used to use Dask arrays wrapped in xr.DataArrays as scalars in min/max value calculation in animation. This used to work with Matplotlib < 2.2.2, now we use actual ndarray 'scalars' instead.
A bug with decode_time has been fixed upstream in xarray 0.10.3
|
@forman This is a really small change. Still, let's keep the process :) Please merge if found OK! |
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
==========================================
+ Coverage 76.4% 76.52% +0.11%
==========================================
Files 81 81
Lines 11398 11398
==========================================
+ Hits 8709 8722 +13
+ Misses 2689 2676 -13
Continue to review full report at Codecov.
|
|
I'll take the liberty to merge this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #585
Closes #579
Starts new dev version in Changes.md