This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Uc9 #5
Merged
Uc9 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A slightly rough around the edges Use Case 9 ect API notebook implementation. Not checked for PEP8, no tests written, not finalized operations design.
… is used. Should come from schema or an attribute in the future.
Add the plotter, some changes to the workflow.
UC9 preliminary workflow as it was presented during the Champion Users meeting.
UC9 workflow has been updated so that it carries out correlation itself. Apart from that, the correlation now takes in a path where to save the result. Type fixed for interpolation method in coregistration.
Merging simple_cdm into uc9. cdm_xarray has been removed. This means that although many operations are not conflicting, they will fail, as they depend on cdm_xarray. io.py changes from simple_cdm have been accepted. This might mean that the uc9 notebook fails to work upon opening a dataset due to chunking/dask mess. Has to be seen. filter.py Changes from simple_cdm have been accepted and incorporated. The processor name changes, so this will fail the notebook, as well as the workflow. Otherwise, should work. timeseries.py uc9 changes have been kept due to timeseries_mean not being implemented in simple_cdm.
After merging, simple_cdm dictated changes have been implemented in all processors, the notebook is changed and tested to still run, as well as the UC9 workflow has been changed accordingly to accommodate the changes. core/io.py was changed again to using native open_mfdataset, due to the open_dataset method not working on my machine.
Adding tests for most of the operations and enhancing the operations while doing so.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably the proper place for a code review discussion!