-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
+ Coverage 71.63% 71.74% +0.11%
==========================================
Files 69 69
Lines 9870 9913 +43
==========================================
+ Hits 7070 7112 +42
- Misses 2800 2801 +1
Continue to review full report at Codecov.
|
This is very exciting! I'll take a look and test how it works! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked out the branch and tried running co-registration from the UC9 notebook with a monitor. Works like charm! Great to have this!
One note though - maybe you can check out doc/source/development_guide/dg-operation-development.rst and add a sentence or two and a quick example about this in the chapter on using Cate monitor?
Even if you don't do this I still want to have this merged :)
What about:
|
Regarding the
... would be nice if Monitor impls could raise this on their own when a method is called but they are already cancelled. Very useful in |
As just discussed: |
* monitor.progress() automatically checks for cancellation * `Cancellation(Excpetion)` is rasie instead of the generic `ÌnteruptedError` * use a context manager function on `Monitor` to create an _observing_ monitor
This adds a
dask.Callback
handler that translates the callbacks emitted from thedask.scheduler
into progress for thecate.Monitor
and allows to cancel the tasks.I've used the new
DaskMonitor
in thesubset
andcoregister
op to show the usage and test its usability.There are some more ops that would profit from using the
DaskMonitor
. Whenever axarray
function invocation results in adask
get or compute function call.fixes #282
Closes #288