Empty resource is created when data are not available

[HelenClifton]

Expected behavior

When opening a local dataset: If a time constraint is selected for which no data are available, a warning should be given to the user and a resource should not be opened.

Actual behavior

A resource of type NoneType is created. This is confusing for the user.

Steps to reproduce the problem

1.In the remote data sources list, select esacci.CLOUD.mon.L3C.CLD_PRODUCTS.multi-sensor.multi-platform.ATSR2-AATSR.2-0.r1 and click “download and/or open remote dataset” button
In “Download Data Source” window:
• Select Time Constraint: 2007-01-01 to 2007-04-01
• Select Region Constraint: Longititude from -100 to 100, Latitude from -60 to 60
• Select Variables from the list: cee, cee_corr_unc, cee_prop_unc, cee_std, cee_unc
• Check “Download and make local data source“
• Leave the unique identifier as the default value
• Ensure “Open dataset from local data source“ is not selected
• Click “Download & Open Local“

2.Wait for download to complete then in the local data sources list, select
local.CLOUD.mon.L3C.CLD_PRODUCTS.multi-sensor.multi-platform.ATSR2-AATSR.2-0.r1
Click “Open local dataset” button
In “Open Local Dataset” window:
• Select Time Constraint: 2007-01-01 to 2007-01-15
• Click on "Open Local"

4.Look at Workspace panel. New resource has been created of type NoneType .

Specifications

Cate 0.9.0-dev.4
Windows 7 Professional

[mzuehlke]

See

• Empty local data sources Empty local data sources #269
• Problem with empty data sources Problem with empty data sources #218

[kbernat]

Checked with CLI, Seems to be fixed.

[mzuehlke]

The error is still present because open_datasource returns None.

[kbernat]

@mzuehlke , @forman
what is expected behaviour when user select timerange out for available temporal coverage of product?

[kbernat]

#351 should fix it now..

[mzuehlke]

Have you tested it ?

[forman]

Removed cu_mandatory because it is implied by cu_review

[HelenClifton]

Still seen in 0.9.0-dev.7, will retest in 1.0.0

[kbernat]

Will handle properly when #393 is done.

[HelenClifton]

Confirmed it is fixed in cate 1.0.0-dev.2. It gives a warning instead.