Fixed two string case issues #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. ValueConstraint.IsSatisifedBy(.. ignoreCase: true) would fail unless BaseType was set to String (from default of Undefined) Fixed by always using string comparison when ignoreCase = true (which must be string) 2. When ValueConstraints had BaseType set to String, facet equality was broken Fixed the logic, which was inversed. TODO: Need to better understand the approach to storing and testing values ValueConstraint - it feels over-elaborate and brittle... Also unclear why we're specialcase using CaseInsensitiveEquals in just PropertySet Facets Equality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValueConstraint.IsSatisifedBy(val, ignoreCase: true)would fail unless BaseType was set to String (from default of Undefined)Fixed by always using string comparison when ignoreCase = true (which must be string)
Fixed the logic, which was inversed.
TODO: Need to better understand the approach to storing and testing values ValueConstraint - it feels over-elaborate and brittle... Also unclear why we're specialcase using CaseInsensitiveEquals in just PropertySet Facets Equality