Skip to content

Commit

Permalink
Minor changes
Browse files Browse the repository at this point in the history
- updated lib
- improved test feedback
- marked some classes obsolete to help move to IdsLib
  • Loading branch information
CBenghi committed Oct 24, 2023
1 parent f5e1746 commit 39cd21a
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<ItemGroup>
<PackageReference Include="FluentAssertions" Version="6.12.0" />
<PackageReference Include="ids-lib" Version="1.0.53" />
<PackageReference Include="ids-lib" Version="1.0.54" />
<PackageReference Include="MartinCostello.Logging.XUnit" Version="0.3.0" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="7.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,11 @@ public void CanReadIdsSamples(string idsFile)
var f = new FileInfo(comb);
f.Exists.Should().BeTrue("test file must be found");

// first we try to load and see if it works with xunit logging
var loadedIds = LoadBuildingSmartIDS(f.FullName, GetXunitLogger());
var logger = GetXunitLogger();
logger.LogInformation("Processing `{filename}`", f.FullName);

// first we try to load and see if it works with xunit logging
var loadedIds = LoadBuildingSmartIDS(f.FullName, logger);
loadedIds.Should().NotBeNull();

// then we load again with mock logger to ensure there are no errors
Expand Down
4 changes: 3 additions & 1 deletion Xbim.InformationSpecifications/Helpers/PropertySetInfo.cs
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
using System.Collections.Generic;
using System;
using System.Collections.Generic;
using System.Linq;

namespace Xbim.InformationSpecifications.Helpers
{
/// <summary>
/// Information about standard property sets defined from bS
/// </summary>
[Obsolete("Prefer similar class in the Ids-lib.")]
public partial class PropertySetInfo
{
/// <summary>
Expand Down
1 change: 1 addition & 0 deletions Xbim.InformationSpecifications/Helpers/SchemaInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ namespace Xbim.InformationSpecifications.Helpers
/// <summary>
/// Provides static methods to get the collection of classes in the published schemas.
/// </summary>
[Obsolete("Prefer similar class in the Ids-lib.")]
public partial class SchemaInfo : IEnumerable<ClassInfo>
{
/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<AssemblyName>Xbim.InformationSpecifications</AssemblyName>
<RootNamespace>Xbim.InformationSpecifications</RootNamespace>
<!-- Remember to update the hardcoded AssemblyVersion property in XIDS-->
<AssemblyVersion>0.3.47</AssemblyVersion>
<AssemblyVersion>0.3.49</AssemblyVersion>
<!-- Remember to update the hardcoded AssemblyVersion property in XIDS-->
<FileVersion>$(AssemblyVersion)</FileVersion>
<Version>$(AssemblyVersion)</Version>
Expand Down Expand Up @@ -49,7 +49,7 @@
<None Include="C:\Data\Dev\XbimPrivate\Xbim.Xids\Xbim.InformationSpecifications\.editorconfig" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="ids-lib" Version="1.0.53" />
<PackageReference Include="ids-lib" Version="1.0.54" />
<PackageReference Include="Nullable" Version="1.3.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
Expand Down
2 changes: 1 addition & 1 deletion Xbim.InformationSpecifications/Xids.AssemblyVersion.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ public partial class Xids
/// This is useful for environments that do not allow to load information from the DLL dynamically
/// (e.g. Blazor).
/// </summary>
public static string AssemblyVersion => "0.3.47";
public static string AssemblyVersion => "0.3.49";
}
}

0 comments on commit 39cd21a

Please sign in to comment.