Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure-based Docker build & push to Docker Hub repo #1354

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

AlexanderGetka-cbica
Copy link
Contributor

Addresses #1344

This now causes our self-hosted Linux build on Ubuntu 16.04 to build and push to the cbica/captk repo on Docker Hub.

I know that at this time the images built on 16.04 are displaying problems in Ubuntu 20.04 -- if we need to swap around the machines / agents used to do this build, we can.

Note that this addition requires the Docker CLI, at least, to be installed on the relevant build agents. I've done this on ubuntu16.04-self-hosting in crete, and I've added the relevant information to the wiki.

This is a draft PR for now to check the builds on Azure -- I need to uncomment the conditional check before merging to master. Will ping the team when this is ready to be reviewed/merged.

@sarthakpati
Copy link
Contributor

This seems to be uploading to docker hub, right? I saw that there were some new builds that were pushed but wasn't sure if this PR triggered it...

@AlexanderGetka-cbica
Copy link
Contributor Author

Sorry @sarthakpati -- didn't see your message. This will push to Docker Hub eventually but it hasn't done so yet.

When it does, the pushes it makes will be tagged with: "latest", "azure-latest", and ${build ID}.

@AlexanderGetka-cbica
Copy link
Contributor Author

OK, crete and its VMs don't have sufficient space to do a docker image build on top of all the existing build stuff. Going to move this to a Microsoft-hosted Ubuntu VM unless there are any objections to that.

@sarthakpati
Copy link
Contributor

@sarthakpati
Copy link
Contributor

OK, crete and its VMs don't have sufficient space to do a docker image build on top of all the existing build stuff. Going to move this to a Microsoft-hosted Ubuntu VM unless there are any objections to that.

Hey @AlexanderGetka-cbica: any update on this?

@AlexanderGetka-cbica
Copy link
Contributor Author

Following some discussion with Mark, I've been intending to check if the testbed VM on crete has enough space. Need to set up a new Azure agent for this... Let me try that right now.

@AlexanderGetka-cbica
Copy link
Contributor Author

Kind of forgot about this for a while... This is ready to be merged. We're now building on Ubuntu 18.04, and the pipeline will only push to Docker Hub from the current master on scheduled or manual runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants