Skip to content

Commit

Permalink
[EuiProvider] Hide unwanted toast until a fix can be done !! (elastic…
Browse files Browse the repository at this point in the history
…#203244)

## Summary

Hiding this until it can be fixed via
elastic#201805 !!

<img width="1341" alt="image"
src="https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288">
  • Loading branch information
shahzad31 authored and CAWilson94 committed Dec 12, 2024
1 parent cf9c63b commit 29f6a1f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ export class ChromeService {
};

// Ensure developers are notified if working in a context that lacks the EUI Provider.
// @ts-expect-error
private handleEuiDevProviderWarning = (notifications: NotificationsStart) => {
const isDev = this.params.coreContext.env.mode.name === 'development';
if (isDev) {
Expand Down Expand Up @@ -240,7 +241,8 @@ export class ChromeService {
}: StartDeps): Promise<InternalChromeStart> {
this.initVisibility(application);
this.handleEuiFullScreenChanges();
this.handleEuiDevProviderWarning(notifications);
// commented out until https://github.com/elastic/kibana/issues/201805 can be fixed
// this.handleEuiDevProviderWarning(notifications);

const globalHelpExtensionMenuLinks$ = new BehaviorSubject<ChromeGlobalHelpExtensionMenuLink[]>(
[]
Expand Down
3 changes: 2 additions & 1 deletion test/plugin_functional/test_suites/shared_ux/eui_provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ export default function ({ getPageObjects, getService }: PluginFunctionalProvide
const testSubjects = getService('testSubjects');
const browser = getService('browser');

describe('EUI Provider Dev Warning', () => {
// skipped until https://github.com/elastic/kibana/issues/201805 is resolved
describe.skip('EUI Provider Dev Warning', () => {
it('shows error toast to developer', async () => {
const pageTitle = 'EuiProvider test - Elastic';

Expand Down

0 comments on commit 29f6a1f

Please sign in to comment.