Use LTS version Node v14 instead of Node v12 as default #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #964 +/- ##
==========================================
- Coverage 62.31% 62.26% -0.06%
==========================================
Files 86 86
Lines 1937 1937
Branches 215 215
==========================================
- Hits 1207 1206 -1
Misses 695 695
- Partials 35 36 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dingyuchen
reviewed
Jul 24, 2022
gycgabriel
reviewed
Jul 29, 2022
| @@ -89,7 +89,7 @@ | |||
| "@types/dompurify": "^2.3.1", | |||
| "@types/jasmine": "^3.8.2", | |||
| "@types/jasminewd2": "2.0.8", | |||
| "@types/node": "~12.12.6", | |||
| "@types/node": "^15.6.1", | |||
There was a problem hiding this comment.
When I put it to 14 it fails haha, I also thought it was like that but actually there's a table that maps typescript versions with @type/node versions haha
https://stackoverflow.com/questions/64924337/i-am-getting-an-error-when-compiling-angular-6-project/65026470#65026470
There was a problem hiding this comment.
Can take a look at the errors here
https://github.com/CATcher-org/CATcher/runs/7536203036?check_suite_focus=true
dingyuchen
approved these changes
Aug 2, 2022
kkangs0226
force-pushed
the
kevin/node14
branch
from
469b050 to
6429b79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Partially fixes #961 (still need to update documentation, which cedric will do).
Fixes #941
Changes Made:
nvm use, it'll set node v14.17.6 as the default version.Proposed Commit Message: