-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --chunk-size
parameter to simgenotype
and fix RuntimeError when reference coordinates extend past the final map file coordinate
#268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlamkin7
approved these changes
Dec 20, 2024
…n variants are beyond end marker
…haptools into feat/chunk-simgts
@aryarm not sure how to add you as a reviewer but would you be able to check my work? |
aryarm
changed the title
feat: add
feat: add Dec 30, 2024
--chunk-size
parameter to simgenotype
--chunk-size
parameter to simgenotype
and fix RuntimeError when reference coordinates extend past the final map file coordinate
mlamkin7
approved these changes
Dec 30, 2024
mlamkin7
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #267
Allows for writing PGEN files while using less memory via a new
--chunk-size
parameter. Also fixes a RuntimeError that would arise when the coordinate of a variant in the reference was greater than the final coordinate in the input.map
file.